fix: set name locations for after/before in the minitest rewriter - #256
Merged
emidoots merged 1 commit intoSep 3, 2026
Merged
Conversation
emidoots
approved these changes
Sep 3, 2026
emidoots
left a comment
emidoots
left a comment
Member
There was a problem hiding this comment.
Indeed, yours looks nicer and less defensive 😄 Thank you for taking a look @christoph-sg !
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the minitest rewriter emits valid locations. For nodes like
before/after, which aren't follow by a name/argument we emitted thenonespan which caused crashes downstream.Test plan
Updated snapshot test
@emidoots I hope this is a cleaner fix for the issue we observed