This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: execute database migrations #17586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emidoots
added
team/internal-contributor
code-insights
Codecov Report
@@ Coverage Diff @@
## main #17586 +/- ##
=======================================
Coverage 51.53% 51.53%
=======================================
Files 1717 1717
Lines 85390 85391 +1
Branches 7652 7652
=======================================
+ Hits 44004 44009 +5
+ Misses 37509 37503 -6
- Partials 3877 3879 +2
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
|
Notifying subscribers in CODENOTIFY files for diff 7252a70...3ef723c.
|
This was referenced Jan 22, 2021
efritz
approved these changes
Jan 24, 2021
emidoots
pushed a commit
that referenced
this pull request
Jan 25, 2021
emidoots
force-pushed
the
sg/insights-execute-migrations
branch
2 times, most recently
from
a93252e to
84c53b3
Compare
This PR causes the database migrations in `migrations/codeinsights` to be executed in dev/testing deployments (not yet in other deployments, as we do not have TimescaleDB deployed yet.) Closes #17219 Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
emidoots
force-pushed
the
sg/insights-execute-migrations
branch
from
84c53b3 to
3ef723c
Compare
emidoots
pushed a commit
that referenced
this pull request
Jan 27, 2021
This reverts commit b877403.
emidoots
pushed a commit
that referenced
this pull request
Jan 27, 2021
emidoots
referenced
this pull request
Jan 27, 2021
It appears that we introduced this in [this PR](https://github.com/sourcegraph/sourcegraph/pull/2975) and, although there is no description, the intent was to prevent [this code from running](https://github.com/sourcegraph/sourcegraph/pull/2971/files#diff-8715b8ced982264b18aaeee9100672eec47a519289087c1d57c9c116b230836eR138). However, it appears that code was never merged - at least blame says it has not existed [since Sourcegraph became open source](https://github.com/sourcegraph/sourcegraph/blame/main/cmd/frontend/internal/auth/userpasswd/handlers.go#L188). Also, the code is already protected by the user agent check - so I don't think we need this. **Most importantly:** having `DEPLOY_TYPE=dev` is *incredibly* bad because it means we are not e2e testing the actual version of Sourcegraph we are releasing! `conf.IsDeployTypeSingleDockerContainer()` will return *false* when this is set, and various dev-only features will be turned on. I only caught this because my PR to run some code in dev-only mode [failed](https://github.com/sourcegraph/sourcegraph/pull/17586). Helps #17218 Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
emidoots
referenced
this pull request
Jan 27, 2021
#17731) It appears that we introduced this in [this PR](https://github.com/sourcegraph/sourcegraph/pull/2975) and, although there is no description, the intent was to prevent [this code from running](https://github.com/sourcegraph/sourcegraph/pull/2971/files#diff-8715b8ced982264b18aaeee9100672eec47a519289087c1d57c9c116b230836eR138). However, it appears that code was never merged - at least blame says it has not existed [since Sourcegraph became open source](https://github.com/sourcegraph/sourcegraph/blame/main/cmd/frontend/internal/auth/userpasswd/handlers.go#L188). Also, the code is already protected by the user agent check - so I don't think we need this. **Most importantly:** having `DEPLOY_TYPE=dev` is *incredibly* bad because it means we are not e2e testing the actual version of Sourcegraph we are releasing! `conf.IsDeployTypeSingleDockerContainer()` will return *false* when this is set, and various dev-only features will be turned on. I only caught this because my PR to run some code in dev-only mode [failed](https://github.com/sourcegraph/sourcegraph/pull/17586). Helps #17218 Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes the database migrations in
migrations/codeinsightsto be executed in dev deployments (not yet in other deployments, as we do not have TimescaleDB deployed yet.)Depends on #17585 and #17588
Helps #17219
Signed-off-by: Stephen Gutekanst stephen@sourcegraph.com