This repository was archived by the owner on Sep 30, 2024. It is now read-only.
dev/ci: do *not* run e2e sourcegraph/server tests with DEPLOY_TYPE=dev #17731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that we introduced this in [this PR](https://github.com/sourcegraph/sourcegraph/pull/2975) and, although there is no description, the intent was to prevent [this code from running](https://github.com/sourcegraph/sourcegraph/pull/2971/files#diff-8715b8ced982264b18aaeee9100672eec47a519289087c1d57c9c116b230836eR138). However, it appears that code was never merged - at least blame says it has not existed [since Sourcegraph became open source](https://github.com/sourcegraph/sourcegraph/blame/main/cmd/frontend/internal/auth/userpasswd/handlers.go#L188). Also, the code is already protected by the user agent check - so I don't think we need this. **Most importantly:** having `DEPLOY_TYPE=dev` is *incredibly* bad because it means we are not e2e testing the actual version of Sourcegraph we are releasing! `conf.IsDeployTypeSingleDockerContainer()` will return *false* when this is set, and various dev-only features will be turned on. I only caught this because my PR to run some code in dev-only mode [failed](https://github.com/sourcegraph/sourcegraph/pull/17586). Helps #17218 Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
efritz
approved these changes
Jan 27, 2021
1 task
emidoots
added
code-insights
27 tasks
emidoots
pushed a commit
that referenced
this pull request
Jan 28, 2021
* dev/ci: do not set DEPLOY_TYPE=dev for backend integration tests These are effectively end-to-end tests, so setting this is very bad for the same reason described in #17731 Should also fix the current CI failure on `main`. Helps #17218 Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com> * code insights: do not run on sourcegraph/server Code Insights will not, at least initially, be supported on demo sourcegraph/server deployments. This codifies that. See #17222 Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that we introduced this in this PR
and, although there is no description, the intent was to prevent this code from running.
However, it appears that code was never merged - at least blame says it has
not existed since Sourcegraph became open source.
Also, the code is already protected by the user agent check - so I don't
think we need this.
Most importantly: having
DEPLOY_TYPE=devis incredibly bad becauseit means we are not e2e testing the actual version of Sourcegraph we are
releasing!
conf.IsDeployTypeSingleDockerContainer()will return falsewhen this is set, and various dev-only features will be turned on.
I only caught this because my PR to run some code in dev-only mode failed.
Helps #17218
Signed-off-by: Stephen Gutekanst stephen@sourcegraph.com