Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Revert "insights: execute database migrations (#17586)" #17701

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Revert "insights: execute database migrations (#17586)" #17701

merged 1 commit into from
Jan 27, 2021

Conversation

@emidoots
Copy link
Member

@emidoots emidoots commented Jan 27, 2021

This reverts #17586 / commit b877403.

This passed in my PR branch on CI, it appears to be failing only in the server docker image - which is super odd because the code shouldn't run there at all: https://github.com/sourcegraph/sourcegraph/pull/17586/files#diff-f086a52919b26953bebd029dda555b5ae3ac420c03816d8f82592a34eed15694R17-R21

I'll debug and re-land this change tomorrow, reverting for now to fix CI.

@emidoots emidoots enabled auto-merge (squash) January 27, 2021 08:53
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jan 27, 2021

Notifying subscribers in CODENOTIFY files for diff b877403...0ed3ec2.

Notify File(s)
@felixfbecker enterprise/internal/insights/insights.go
@keegancsmith internal/conf/conftypes/conftypes.go

@emidoots emidoots merged commit 5fca3e6 into main Jan 27, 2021
@emidoots emidoots deleted the sg/fix-ci branch January 27, 2021 08:54
@sourcegraph-bot sourcegraph-bot mentioned this pull request Jan 27, 2021
Merged
1 task
emidoots pushed a commit that referenced this pull request Jan 28, 2021
Revert "Revert "insights: execute database migrations (#17586)" (#17701…
d7e29b9 
…)"

This reverts commit 5fca3e6.

This brings back the execution of code insights database migrations, which
is safe to do now that #17731 has landed.

Helps #17218

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
@emidoots emidoots added code-insights Issues related to the Code Insights product team/internal-contributor labels Jan 28, 2021
@emidoots emidoots added this to the 3.25 milestone Jan 28, 2021
@sourcegraph-bot sourcegraph-bot mentioned this pull request Jan 28, 2021
Closed
emidoots pushed a commit that referenced this pull request Jan 28, 2021
Revert "Revert "insights: execute database migrations (#17586)" (#17701…
77b3ce3 
…)" (#17732)

This reverts commit 5fca3e6.

This brings back the execution of code insights database migrations, which
is safe to do now that #17731 has landed.

Helps #17218

Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
@sourcegraph-bot sourcegraph-bot mentioned this pull request Jan 28, 2021
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mrnugget mrnugget mrnugget approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-insights Issues related to the Code Insights product slimsag-basic-scaffolding

Projects

None yet

Milestone

3.25

Development

Successfully merging this pull request may close these issues.

4 participants

@emidoots @sourcegraph-bot @mrnugget