This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintellify: Fix hover flicker #33988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismwendt
commented
Apr 16, 2022
| highlightedRange, | ||
| hoverOrError, | ||
| hoveredTokenElement, | ||
| hoverOverlayPosition: undefined, |
Contributor
Author
There was a problem hiding this comment.
Setting this to undefined was making the hover disappear immediately, then another value would be emitted by some other Observable that would set the position again and make the hover reappear, causing flicker.
For context, the original intent of this line was: "Reset the hover position, it's gonna be repositioned after the hover was rendered"
efritz
approved these changes
Apr 19, 2022
Contributor
|
Sorry! Completely missed that PR. Good stuff! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/sourcegraph/sourcegraph/issues/33985
Test plan
Ran locally.
App preview:
Check out the client app preview documentation to learn more.