Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

codeintellify: Fix hover flicker #33988

Merged
chrismwendt merged 1 commit into from
Apr 19, 2022
Merged

codeintellify: Fix hover flicker #33988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/codeintellify/src/hoverifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,6 @@ export function createHoverifier<C extends object, D, A>({
highlightedRange,
hoverOrError,
hoveredTokenElement,
hoverOverlayPosition: undefined,
Copy link
Contributor Author

@chrismwendt chrismwendt Apr 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this to undefined was making the hover disappear immediately, then another value would be emitted by some other Observable that would set the position again and make the hover reappear, causing flicker.

For context, the original intent of this line was: "Reset the hover position, it's gonna be repositioned after the hover was rendered"

CleanShot 2022-04-15 at 19 45 16@2x

From sourcegraph/codeintellify#196

})
}
)
Expand Down