chore: remove LSIF leftovers, keeping only SCIP support #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed lsif.go reference from BUILD.bazel - Removed unused LSIF/SCIP dependency from BUILD.bazel - Updated upload API path from /.api/lsif/upload to /.api/scip/upload - Removed deprecated 'src lsif' alias reference from README - Removed LSIF-specific CODEOWNERS rule - Note: lsif.enforceAuth still applies to SCIP uploads per configuration Amp-Thread-ID: https://ampcode.com/threads/T-0b0441d0-8980-4586-ae91-2059389ab3b4
| "format.go", | ||
| "headers.go", | ||
| "login.go", | ||
| "lsif.go", |
There was a problem hiding this comment.
I think these build files are unused, because this was referring to a non-existent file lsif.go.
https://ampcode.com/threads/T-2e647c07-ac30-4151-a359-3a4d8bc46379
https://sourcegraph.slack.com/archives/C04MYFW01NV/p1759386088267129
varungandhi-src
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amp-Thread-ID: https://ampcode.com/threads/T-0b0441d0-8980-4586-ae91-2059389ab3b4
Test plan
N/A