Skip to content

chore: remove LSIF leftovers, keeping only SCIP support #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
+3 −6
Merged

chore: remove LSIF leftovers, keeping only SCIP support #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
cmd/src/lsif* @sourcegraph/team-graph
cmd/src/code_intel* @sourcegraph/team-graph

cmd/src/search* @sourcegraph/search-platform
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Is your Sourcegraph instance behind a custom auth proxy? See [auth proxy configu
- `src config` - manage global, org, and user settings
- `src extsvc` - manage external services (repository configuration)
- `src extensions` - manage extensions
- `src code-intel` - manages Code Intelligence data (deprecated alias: `src lsif`)
- `src code-intel` - manages Code Intelligence data
- `src serve-git` - serves your local git repositories over HTTP for Sourcegraph to pull
- `src version` - check version and guaranteed-compatible version for your Sourcegraph instance

Expand Down
2 changes: 0 additions & 2 deletions cmd/src/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ go_library(
"format.go",
"headers.go",
"login.go",
"lsif.go",
Copy link
Contributor

@varungandhi-src varungandhi-src Oct 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these build files are unused, because this was referring to a non-existent file lsif.go.

https://ampcode.com/threads/T-2e647c07-ac30-4151-a359-3a4d8bc46379

https://sourcegraph.slack.com/archives/C04MYFW01NV/p1759386088267129

"main.go",
"orgs.go",
"orgs_create.go",
Expand Down Expand Up @@ -132,7 +131,6 @@ go_library(
"@com_github_sourcegraph_scip//bindings/go/scip",
"@com_github_sourcegraph_sourcegraph_lib//batches",
"@com_github_sourcegraph_sourcegraph_lib//batches/template",
"@com_github_sourcegraph_sourcegraph_lib//codeintel/lsif/scip",
"@com_github_sourcegraph_sourcegraph_lib//codeintel/upload",
"@com_github_sourcegraph_sourcegraph_lib//errors",
"@com_github_sourcegraph_sourcegraph_lib//output",
Expand Down
2 changes: 1 addition & 1 deletion cmd/src/code_intel_upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ func makeCodeIntelUploadURL(uploadID int) (string, error) {
return "", err
}

graphqlID := base64.URLEncoding.EncodeToString([]byte(fmt.Sprintf(`LSIFUpload:%d`, uploadID)))
graphqlID := base64.URLEncoding.EncodeToString([]byte(fmt.Sprintf(`SCIPUpload:%d`, uploadID)))
url.Path = codeintelUploadFlags.repo + "/-/code-intelligence/uploads/" + graphqlID
url.User = nil
return url.String(), nil
Expand Down
2 changes: 1 addition & 1 deletion cmd/src/code_intel_upload_vendored.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ func makeUploadURL(opts uploadRequestOptions) (*url.URL, error) {

path := opts.SourcegraphInstanceOptions.Path
if path == "" {
path = "/.api/lsif/upload"
path = "/.api/scip/upload"
}

parsedUrl, err := url.Parse(opts.SourcegraphInstanceOptions.SourcegraphURL + path)
Expand Down
Loading