chore(ci): always use go version in .tool-versions #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup-go@v6 supports reading in .tool-versions which means we will now always run the same version we run in local dev. This is also a better version to use than go.mod since that is a minimum version. Test Plan: CI
burmudar
approved these changes
Nov 11, 2025
Member
Author
|
Well it seems this feature wasn't really tested lol. Was committed two weeks ago and it fails for us and check out this issue actions/setup-go#680 |
This isn't a tagged release yet, but supports a feature we want that will be released soon. I am monitoring the upstream issue for when we can switch back to tags.
Member
Author
|
I really like this feature and will monitor the upstream action for when they will release it. For now I am pinning setup-go to the latest commit which supports this feature. So will land this if CI is happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup-go@v6 supports reading in .tool-versions which means we will now always run the same version we run in local dev. This is also a better version to use than go.mod since that is a minimum version.
Test Plan: CI