security: use traversal safe os.Root for FS operations #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evict
force-pushed
the
vr/servegit/use-traversal-safe-api
branch
2 times, most recently
from
4cc942a to
106ec65
Compare
evict
force-pushed
the
vr/servegit/use-traversal-safe-api
branch
from
106ec65 to
6d2bdce
Compare
Member
|
I will review this closely tomorrow morning! |
evict
commented
Dec 4, 2025
keegancsmith
approved these changes
Dec 4, 2025
evict
force-pushed
the
vr/servegit/use-traversal-safe-api
branch
from
6d2bdce to
d53bf3a
Compare
evict
force-pushed
the
vr/servegit/use-traversal-safe-api
branch
from
47e7186 to
b43f159
Compare
evict
changed the title
evict
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement a path traversal safe file system to be used with
serve-gitTest plan
Tested cloning repositories with
serve-git, works fine. Doesn't download symlinks.