Skip to content

Bump default action timeout from 2min to 15min #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Bump default action timeout from 2min to 15min #168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98f3245
Bump default action timeout from 2min to 15min
mrnugget Mar 30, 2020
7ae803e
Increase timeout to 60min
mrnugget Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/src/actions_exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func userCacheDir() (string, error) {
return filepath.Join(userCacheDir, "sourcegraph-src"), nil
}

const defaultTimeout = 2 * time.Minute
const defaultTimeout = 60 * time.Minute

func init() {
usage := `
Expand Down Expand Up @@ -139,7 +139,7 @@ Format of the action JSON files:
clearCacheFlag = flagSet.Bool("clear-cache", false, "Remove possibly cached results for an action before executing it.")

keepLogsFlag = flagSet.Bool("keep-logs", false, "Do not remove execution log files when done.")
timeoutFlag = flagSet.Duration("timeout", defaultTimeout, "The maximum duration a single action run can take (excluding the building of Docker images).")
timeoutFlag = flagSet.Duration("timeout", defaultTimeout, "The maximum duration a single action run can take.")

createPatchSetFlag = flagSet.Bool("create-patchset", false, "Create a patch set from the produced set of patches. When the execution of the action fails in a single repository a prompt will ask to confirm or reject the patch set creation.")
forceCreatePatchSetFlag = flagSet.Bool("force-create-patchset", false, "Force creation of patch set from the produced set of patches, without asking for confirmation even when the execution of the action failed for a subset of repositories.")
Expand Down