Bump default action timeout from 2min to 15min #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #159. I think we could (should?) go even higher, since most of the actions I ran take their time, especially on macOS.
|
Hmm what I've seen CI providers do was "minutes since last log emission", to detect really long running tasks, and have a global timeout of 1h or even more |
|
Then let's bump it to 60min and defer on implementing fine-grained timeouts until we have more experience using it, because right now I never want to run into a timeout. |
eseliger
approved these changes
Mar 30, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Bump default action timeout from 2min to 15min This fixes #159. I think we could (should?) go even higher, since most of the actions I ran take their time, especially on macOS. * Increase timeout to 60min
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #159.
I think we could (should?) go even higher, since most of the actions I ran take their time, especially on macOS.