Skip to content

Conversation

@mrnugget
Copy link
Contributor

Looks like we missed this.

@mrnugget mrnugget requested review from eseliger and ryanslade April 21, 2020 08:11
"minLength": 1
},
"cacheDirs": {
"description": "Names of directories to create for in a temporary location and mount into each \"docker\" step container under the specified name.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Names of directories to create for in a temporary location and mount into each \"docker\" step container under the specified name.",
"description": "Names of directories to create in a temporary location and mount into each \"docker\" step container under the specified name.",

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but I don’t think min items needs to be 1, could be omitted?

@mrnugget mrnugget merged commit 03245e4 into master Apr 21, 2020
scjohns pushed a commit that referenced this pull request Apr 24, 2023
* Add cacheDirs to action definition JSON schema

* Incorporate feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants