Skip to content

Conversation

@efritz
Copy link
Contributor

@efritz efritz commented May 7, 2020

This slack message raises a concern about upload failures when the dotcom instance is having issues. This occurs when the frontend is not reachable, or a 500-level error occurs because the precise-code-intel backend is having issues.

This PR adds a flag to print the error but exit 0 when they occur so that we do not fail open-source builds when our own service is having issues.

@efritz efritz requested review from garobrik and rvantonder May 7, 2020 16:38
Copy link
Contributor

@garobrik garobrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

Copy link
Contributor

@rvantonder rvantonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@efritz efritz merged commit 0001a82 into master May 7, 2020
@efritz efritz deleted the ignore-upload-failure branch May 7, 2020 19:24
scjohns pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants