Skip to content

Add flag to ignore lsif upload failures #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2020
Merged

Add flag to ignore lsif upload failures #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cmd/src/lsif_upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ Examples:
indexerNameFlag = flagSet.String("indexerName", "", `The name of the indexer that generated the dump. This will override the 'toolInfo.name' field in the metadata vertex of the LSIF dump file. This must be supplied if the indexer does not set this field (in which case the upload will fail with an explicit message).`)
openFlag = flagSet.Bool("open", false, `Open the LSIF upload page in your browser.`)
apiFlags = newAPIFlags(flagSet)

ignoreUploadFailures = flagSet.Bool("ignore-upload-failure", false, `Exit with status code zero on upload failure.`)
)

handler := func(args []string) error {
Expand Down Expand Up @@ -209,6 +211,10 @@ Examples:
// Perform the request.
resp, err := http.DefaultClient.Do(req)
if err != nil {
if *ignoreUploadFailures {
fmt.Printf("error: %s\n", err)
return nil
}
return err
}
defer resp.Body.Close()
Expand Down Expand Up @@ -236,6 +242,11 @@ Examples:
fmt.Println("See https://github.com/sourcegraph/src-cli#authentication")
fmt.Println("")
}

if resp.StatusCode == http.StatusInternalServerError && *ignoreUploadFailures {
fmt.Printf("error: %s\n\n%s", resp.Status, body)
return nil
}
return fmt.Errorf("error: %s\n\n%s", resp.Status, body)
}

Expand Down