Remove -endpoint flag #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanslade
force-pushed
the
simplify-config
branch
from
7e86a3b to
c338c39
Compare
|
Some of our LSIF docs mentions |
This change removes the -endpoint flag It also ensures the following: * Both env vars override the config file. * If a config file exists, either zero or both env vars must be specified. It is an error if only one is specified. This is to avoid confusion; we never merge config from the file and env vars.
ryanslade
force-pushed
the
simplify-config
branch
from
c338c39 to
2fbad1d
Compare
|
This will likely break some admins’ usage of this script, which they may not have any good visibility into. We’ll need to think about: how do we communicate breaking changes to the CLI? Before merging this |
|
Adding more color to my comment: I think just documenting this in a new CHANGELOG.md file would be good enough. If you want to get more fancy, you could detect if |
|
I've added a skeleton changelog, I assume we didn't want any historical changes in there? |
|
Yep, looks good! |
ryanslade
added a commit
that referenced
this pull request
Jun 26, 2020
This reverts commit a167443. This broke some existing users of src-cli. Another PR will make this a more graceful deprecation.
ryanslade
added a commit
that referenced
this pull request
Jun 26, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Remove -endpoint flag This change removes the -endpoint flag It also ensures the following: * Both env vars override the config file. * If a config file exists, either zero or both env vars must be specified. It is an error if only one is specified. This is to avoid confusion; we never merge config from the file and env vars. * Add CHANGELOG.md * Add another pending change
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the -endpoint flag
It also ensures the following:
specified. It is an error if only one is specified. This is
to avoid confusion; we never merge config from the file and env vars.
Closes: #222