Conversation
unknwon
approved these changes
Aug 11, 2020
mrnugget
approved these changes
Aug 11, 2020
Member
|
@LawnGnome this is what I did for our main repo, maybe a little more involved than needed for this repo: https://github.com/sourcegraph/sourcegraph/pull/11453#issuecomment-668170783 There is also a useful script to automate the update of open PRs: https://github.com/sourcegraph/sourcegraph/pull/11453#issuecomment-669041714 |
e179954 to
78666c8
Compare
78666c8 to
16f56ab
Compare
LawnGnome
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Aug 21, 2020
This needs to be merged after sourcegraph/src-cli#262.
LawnGnome
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Aug 21, 2020
This needs to be merged after sourcegraph/src-cli#262.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings
src-cliinto line with our other important repositories.I don't believe we have any other hardcoded references toThere now is: https://github.com/sourcegraph/sourcegraph/pull/13228 will fix that, once this is merged.src-cli'smasterbranch across our organisation, based on this search.Process wise, here's how I intend to proceed after approval:
mastertomain.main.maininstead ofmaster.If I've missed anything, I'd definitely appreciate a heads up! 😃