Do not re-execute campaign spec steps when the diff is still valid #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LawnGnome
approved these changes
Aug 26, 2020
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
This is an elegant solution. (Actually, quite a bit more elegant than I expected it to be when we talked about it!)
Since it took me a couple of reads to get why this was OK, I'd love a touch more commentary in the cache path, but otherwise I think this is good to go. 👍
mrnugget
approved these changes
Aug 27, 2020
Contributor
mrnugget
left a comment
mrnugget
left a comment
There was a problem hiding this comment.
Wow, this was ... less hairy than I thought it would be. Well done! 👏
Agree with Adam that a comments would be cool
Author
|
Credit for elegance of the solution goes entirely to Erik. 😄 |
Contributor
|
Left my thoughts here #282 (comment) (and linking to them because it's easy to miss in GitHub's PR view). I'm going to merge this now so it's in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the JSON marshalling of
Taskto ignore theTemplate, this makes it so that changes to the template (assuming no changes tosteps:oron:) will serialize to the same JSON, so the previous run is found in the cache.We then reuse the diff from the cache, and otherwise use the new spec.
Testing: I tested this manually with the hello world campaign. I think everything worked correctly, and that my errors were unrelated to this feature, but I'd really appreciate someone else running a campaign and verifying that this works for them, too.
Closes #13172