do not crash if termbox fails to init #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LawnGnome
approved these changes
Aug 27, 2020
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
Seems fair. I thought about whether we should try to look at the COLUMNS and LINES environment variables before defaulting to 80x25, but realistically they're not usually available, so let's not complicate matters.
eseliger
approved these changes
Aug 27, 2020
Member
eseliger
left a comment
eseliger
left a comment
There was a problem hiding this comment.
I wonder what the cause is, but seems like a fair fix
Contributor
|
How did you find out it's termbox? Yesterday, when running into the |
Author
|
The call stack made it pretty clear that it was failing on init. (This was in VS Code where it failed, and I had a call-stack up to that point.) |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to debug in VS Code, but termbox fails to init in that environment for some reason. Since all we want is the size, how about if we fall back to a reasonable default (80x25) in that case?