Fix flaky executor timeout test #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the test a longer timeout to ensure that we've reached `runSteps` when the timeout kicks in, even on slow CI machines. And it changes the "sleep" to a power-nap-sleep-loop so that we only have to wait 100ms until the test returns.
eseliger
approved these changes
Oct 16, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This gives the test a longer timeout to ensure that we've reached `runSteps` when the timeout kicks in, even on slow CI machines. And it changes the "sleep" to a power-nap-sleep-loop so that we only have to wait 100ms until the test returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the test a longer timeout to ensure that we've reached
runStepswhen the timeout kicks in, even on slow CI machines.And it changes the "sleep" to a power-nap-sleep-loop so that we only
have to wait 100ms until the test returns.