Skip to content

Fix flaky executor timeout test #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix flaky executor timeout test #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions internal/campaigns/executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,15 @@ func TestExecutor_Integration(t *testing.T) {
{repo: srcCLIRepo, files: map[string]string{"README.md": "line 1"}},
},
steps: []Step{
{Run: `sleep 1`, Container: "alpine:13"},
// This needs to be a loop, because when a process goes to sleep
// it's not interruptible, meaning that while it will receive SIGKILL
// it won't exit until it had its full night of sleep.
// So.
// Instead we take short powernaps.
{Run: `while true; do echo "zZzzZ" && sleep 0.05; done`, Container: "alpine:13"},
},
executorTimeout: 20 * time.Millisecond,
wantErrInclude: "execution in github.com/sourcegraph/src-cli failed: Timeout reached. Execution took longer than 20ms.",
executorTimeout: 100 * time.Millisecond,
wantErrInclude: "execution in github.com/sourcegraph/src-cli failed: Timeout reached. Execution took longer than 100ms.",
},
}

Expand Down