campaigns: temporary switch back to bind for non-root #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be reverted once we land #434.
LawnGnome
commented
Jan 21, 2021
|
|
||
| uids[uid] = struct{}{} | ||
| if len(uids) > 1 { | ||
| if len(uids) > 1 || uid != 0 { |
There was a problem hiding this comment.
This is ugly, but simplifies the revert later.
eseliger
approved these changes
Jan 21, 2021
LawnGnome
added a commit
that referenced
this pull request
Jan 21, 2021
This reverts commit a35c2e7.
LawnGnome
added a commit
that referenced
this pull request
Jan 22, 2021
This reverts commit a35c2e7.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This can be reverted once we land #434.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be reverted once we land #434.