Skip to content

campaigns: temporary switch back to bind for non-root #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2021
Merged

campaigns: temporary switch back to bind for non-root #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/campaigns/workspace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func detectBestWorkspaceCreator(ctx context.Context, steps []Step) workspaceCrea
}

uids[uid] = struct{}{}
if len(uids) > 1 {
if len(uids) > 1 || uid != 0 {
Copy link
Contributor Author

@LawnGnome LawnGnome Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ugly, but simplifies the revert later.

return workspaceCreatorBind
}
}
Expand Down
7 changes: 3 additions & 4 deletions internal/campaigns/workspace_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,13 @@ func TestBestWorkspaceCreator(t *testing.T) {
"same user": {
behaviours: map[string]expect.Behaviour{
"foo": {Stdout: []byte("1000\n")},
"bar": {Stdout: []byte("1000\n")},
},
want: workspaceCreatorVolume,
want: workspaceCreatorBind,
},
"different user": {
behaviours: map[string]expect.Behaviour{
"foo": {Stdout: []byte("1000\n")},
"bar": {Stdout: []byte("0\n")},
"foo": {Stdout: []byte("0\n")},
"bar": {Stdout: []byte("1000\n")},
},
want: workspaceCreatorBind,
},
Expand Down