Skip to content

Conversation

@stimut
Copy link
Contributor

@stimut stimut commented May 21, 2021

The output of src version uses inconsistent capitalization of
"version", and the recommended version can sometimes be a downgrade
compared to what is actually installed. The changes in this PR are to:

  • standardize on lower-case v in "version"
  • add or later to output of recommended version

Fixes sourcegraph/sourcegraph#16850

The output of `src version` uses inconsistent capitalization of
"version", and the recommended version can sometimes be a downgrade
compared to what is actually installed. The changes in this PR are to:

- standardize on lower-case `v` in "version"
- add `or later` to output of recommended version

Fixes sourcegraph/sourcegraph#16850
@stimut stimut marked this pull request as ready for review May 21, 2021 12:43
Copy link
Contributor

@mrnugget mrnugget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stimut!

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrnugget mrnugget merged commit c670e13 into sourcegraph:main May 21, 2021
@stimut stimut deleted the clean-version-output branch May 21, 2021 13:10
scjohns pushed a commit that referenced this pull request Apr 24, 2023
The output of `src version` uses inconsistent capitalization of
"version", and the recommended version can sometimes be a downgrade
compared to what is actually installed. The changes in this PR are to:

- standardize on lower-case `v` in "version"
- add `or later` to output of recommended version

Fixes sourcegraph/sourcegraph#16850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix src version recommended version

3 participants