servegit: decompress input to git-upload-pack #547
Conversation
Previously we did http.Error. However, we have already set the HTTP response code. Additionally we may have already written other data. So we instead just write out the error message on a new line. This error can often be swallowed by the git client. So we additionally log the error to the debug log.
Ensure that if the Content-Encoding of a servegit request is gzip then we read it as a compressed input. git-upload-pack does not accept gzipped input and fails. This is only sometimes gzipped and I'm not sure of the conditions so we can't rely on it being always or never encoded. This is a port of sourcegraph/sourcegraph 8e1e58c. Co-authored-by: Eric Fritz <eric@sourcegraph.com>
|
Is there any other places that we need to update? (a la https://github.com/sourcegraph/sourcegraph/pull/21067#pullrequestreview-663133145) |
Yes this could make sense to share. We have a lot more instrumentation in gitserver version (which was a copy of this version originally I think :) ). I've added to my personal backlog to explore next month.
I believe this is everything. A quick search for something specific to this indicates that. https://sourcegraph.com/search?q=context:%40keegan+x-git-upload-pack-advertisement&patternType=regexp |
Ensure that if the Content-Encoding of a servegit request is gzip then we read it as a compressed input. git-upload-pack does not accept gzipped input and fails. This is only sometimes gzipped and I'm not sure of the conditions so we can't rely on it being always or never encoded. This is a port of sourcegraph/sourcegraph 8e1e58c. Co-authored-by: Eric Fritz <eric@sourcegraph.com>
Ensure that if the Content-Encoding of a servegit request is gzip then we read it as a compressed input. git-upload-pack does not accept gzipped input and fails. This is only sometimes gzipped and I'm not sure of the conditions so we can't rely on it being always or never encoded.
This is a port of https://github.com/sourcegraph/sourcegraph/pull/21067
Co-authored-by: @efritz