executor UI: extract StepsExecutionUI from TaskExecutionUI and implement it in TUI and JSON #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
approved these changes
Sep 3, 2021
|
@sourcegraph/batchers Merging this after @eseliger discussed this a bit. We both think that we need to change the events and what data is logged when anyway, so we won't sweat that now until we know more about what the workflow in the web UI will be and which data we need to display. |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
…ent it in TUI and JSON (#606) This is a follow-up to #597 and splits up the existing interface into two. That allows us to remove all formatting from `runSteps` and `executeSingleStep` and also provide more information for the JSON interface (e.g. when a step is finished). **Note**: the `OPERATION` and `STATUS` fields in the `logEvents` don't make a lot of sense. Happy to change everything there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #597 and splits up the existing interface into two.
That allows us to remove all formatting from
runStepsandexecuteSingleStepand also provide more information for the JSON interface (e.g. when a step is finished).Note: the
OPERATIONandSTATUSfields in thelogEventsdon't make a lot of sense. Happy to change everything there.