gitindex: fallback when cat-file filters are unsupported - #1094
Merged
keegancsmith merged 1 commit intoJul 24, 2026
Conversation
keegancsmith
changed the title
burmudar
approved these changes
Jul 24, 2026
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git cat-file --filterwas introduced in Git 2.50. On older Git versions the command exits immediately, while the reader only observes EOF and indexing fails instead of using the existing fallback.Probe the actual
cat-file --filtercapability before selecting the batch reader, which also accommodates vendor backports, and fall back to go-git when unsupported. The feature-specific reader test now skips when the installed Git lacks this capability.The source change was verified with a full
go test -short ./...run under Git config isolation. The fallback and skip paths passed on Git 2.39.5, and the supported path passed against real Git 2.53.0.