feat(skills/reviewing-feature-progress): add GitHub-surface sweep step to the checkpoint#27
Merged
Merged
Conversation
…p to the checkpoint
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the reviewing-feature-progress checkpoint skill to include an explicit “GitHub-surface sweep” so the checkpoint validates (and reconciles) the GitHub-facing prose (epic/sub-issue/PR bodies) against the final feature-branch shape before integration review.
Changes:
- Add a new Step 5 to sweep the epic body, all sub-issue bodies (beyond acceptance criteria), and all open PR bodies for drift vs the final branch.
- Renumber subsequent steps and extend the synthesized gap list to include body-sweep fixes.
- Add a new red-flag row to counter the assumption that per-decision reconciliation eliminates the need for a final sweep.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…relative clause Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J1vgUwZZpzavETACT3fXPM
…the Step 6 cross-reference The GitHub-surface sweep renumbers end-to-end verification from Step 6 to Step 7; this pointer referenced the old number. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J1vgUwZZpzavETACT3fXPM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The checkpoint verifies code against plan/contracts/criteria and the state file against reality, but never reads the GitHub prose an external reviewer sees first: the epic body (design overview, mermaid diagrams), sub-issue approach prose beyond the
## Acceptance criteriasections, and PR bodies. After a long review cycle changes decisions mid-flight, the per-decision reconciliation mechanisms (writing-github-issues Step 2D, opening-a-pull-request body reconciliation) each cover only the surface where the decision was made — under momentum some surface is always missed. In a live session, a final manual sweep found 8 of 14 GitHub bodies stale (including a mermaid diagram showing a removed mechanism and a PR body claiming a test that had been deleted); a baseline agent running this skill's checkpoint listed every code/criteria/state check but never opened a single body.Change
skills/reviewing-feature-progress/SKILL.mdgains a numbered Step 5 (GitHub-surface sweep): walk the epic body, every sub-issue body, and every open PR body against the final branch shape, fixing through the matching mechanism (Step 2B/2D for issues, body-only reconciliation for PRs). Old Steps 5-7 renumber to 6-8; the synthesis list gains a body-sweep bullet; one red-flag row counters "they were reconciled at each decision, no need to re-read". The renumbering is followed where it's referenced:skills/testing-end-to-end/SKILL.md's pointer to the end-to-end verification step updates from Step 6 to Step 7.Verification (writing-skills RED → GREEN)