Skip to content

Add many more clang-tidy stricter checks - #2747

Merged
jviotti merged 5 commits into
mainfrom
clang-tidy-stronger
Sep 2, 2026
Merged

Add many more clang-tidy stricter checks#2747
jviotti merged 5 commits into
mainfrom
clang-tidy-stronger

Conversation

@jviotti

@jviotti jviotti commented Aug 18, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 126b6b1 Previous: 14af3c9 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.186790071569736 ns/iter 2.0558566288813864 ns/iter 1.06
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.8233210052737183 ns/iter 2.2008109310740958 ns/iter 1.28
Regex_Period_Asterisk 2.311522760147652 ns/iter 2.0172929143205383 ns/iter 1.15
Regex_Group_Period_Asterisk_Group 2.3372710652713744 ns/iter 2.034647877337778 ns/iter 1.15
Regex_Period_Plus 2.428114603432528 ns/iter 2.3668436740783787 ns/iter 1.03
Regex_Period 2.4722753507551976 ns/iter 2.3616177023403604 ns/iter 1.05
Regex_Caret_Period_Plus_Dollar 2.5504298223636592 ns/iter 2.532850616940956 ns/iter 1.01
Regex_Caret_Group_Period_Plus_Group_Dollar 2.7232051133556037 ns/iter 2.3629257813255506 ns/iter 1.15
Regex_Caret_Period_Asterisk_Dollar 2.2080318518046678 ns/iter 1.9341871457315782 ns/iter 1.14
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.1283970094504134 ns/iter 2.379666983355669 ns/iter 0.89
Regex_Caret_X_Hyphen 7.036608317366629 ns/iter 7.701032086835618 ns/iter 0.91
Regex_Period_Md_Dollar 25.95243919233557 ns/iter 25.919940551894474 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 6.915726968381155 ns/iter 5.670742123911041 ns/iter 1.22
Regex_Caret_Period_Range_Dollar 2.935193791263246 ns/iter 2.4646192646211214 ns/iter 1.19
Regex_Nested_Backtrack 35.72658613835674 ns/iter 38.33361872009159 ns/iter 0.93
JSON_Array_Of_Objects_Unique 515.8755245336856 ns/iter 541.6629510671395 ns/iter 0.95
JSON_Parse_1 5801.617698536389 ns/iter 3925.8874993564154 ns/iter 1.48
JSON_Parse_Real 8381.294700285755 ns/iter 6378.9420697834485 ns/iter 1.31
JSON_Parse_Decimal 9415.093780417978 ns/iter 7036.131438890205 ns/iter 1.34
JSON_Parse_Schema_ISO_Language 3853218.4708993365 ns/iter 2670355.599236648 ns/iter 1.44
JSON_Parse_Integer 4919.913665941759 ns/iter 4457.687767655077 ns/iter 1.10
JSON_Parse_String_NonSSO_Plain 5106.878231806307 ns/iter 4384.918585789219 ns/iter 1.16
JSON_Parse_String_SSO_Plain 2231.2501087351634 ns/iter 2371.9470991183653 ns/iter 0.94
JSON_Parse_String_Escape_Heavy 21725.920647864503 ns/iter 20735.85398023057 ns/iter 1.05
JSON_Parse_Object_Short_Keys 7653.979448846627 ns/iter 6697.297936593248 ns/iter 1.14
JSON_Parse_Object_Scalar_Properties 3553.3423456737078 ns/iter 3664.9572883466517 ns/iter 0.97
JSON_Parse_Object_Array_Properties 4628.124679038548 ns/iter 4345.562756003915 ns/iter 1.07
JSON_Parse_Object_Object_Properties 4995.881284171878 ns/iter 5029.349596281367 ns/iter 0.99
JSON_Parse_Nested_Containers 33343.789692897415 ns/iter 35423.98625973891 ns/iter 0.94
JSON_From_String_Copy 14.676434603416435 ns/iter 13.349350517269912 ns/iter 1.10
JSON_From_String_Temporary 9.609539646307352 ns/iter 9.039423984342532 ns/iter 1.06
JSON_Number_To_Double 55.54359635989255 ns/iter 43.8344509333591 ns/iter 1.27
JSON_Object_At_Last_Key/8 5.905121721572843 ns/iter 5.186078465723726 ns/iter 1.14
JSON_Object_At_Last_Key/32 17.508950946816952 ns/iter 20.084354190304975 ns/iter 0.87
JSON_Object_At_Last_Key/128 82.78014847731005 ns/iter 76.18731826856029 ns/iter 1.09
JSON_Object_At_Last_Key/512 292.3007549893007 ns/iter 303.241743059844 ns/iter 0.96
JSON_Fast_Hash_Helm_Chart_Lock 86.41954070318101 ns/iter 85.63191793743896 ns/iter 1.01
JSON_Equality_Helm_Chart_Lock 252.58427937099765 ns/iter 263.09617612724463 ns/iter 0.96
JSON_Divisible_By_Decimal 237.62748442711356 ns/iter 286.0829118477421 ns/iter 0.83
JSON_String_Equal/10 9.703079333880526 ns/iter 10.718977971953878 ns/iter 0.91
JSON_String_Equal/100 9.240981479398451 ns/iter 9.457519920561758 ns/iter 0.98
JSON_String_Equal_Small_By_Perfect_Hash/10 0.4277887938689166 ns/iter 0.4549893770943861 ns/iter 0.94
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 4.727669631656979 ns/iter 5.456887080000001 ns/iter 0.87
JSON_String_Fast_Hash/10 3.161254860417703 ns/iter 4.40700278321417 ns/iter 0.72
JSON_String_Fast_Hash/100 3.0554022603019093 ns/iter 3.579198043134501 ns/iter 0.85
JSON_String_Key_Hash/10 2.4029653260827355 ns/iter 2.773393679651961 ns/iter 0.87
JSON_String_Key_Hash/100 3.6697598677779246 ns/iter 3.5006405354822503 ns/iter 1.05
JSON_Object_Defines_Miss_Same_Length 4.163971021048453 ns/iter 4.58992106849856 ns/iter 0.91
JSON_Object_Defines_Miss_Too_Small 3.485561486794928 ns/iter 4.228693388615171 ns/iter 0.82
JSON_Object_Defines_Miss_Too_Large 3.5632576981214448 ns/iter 4.048993480598685 ns/iter 0.88
Pointer_Object_Traverse 30.29363075091832 ns/iter 36.32044354808504 ns/iter 0.83
Pointer_Object_Try_Traverse 67.53660666369822 ns/iter 67.88966579332661 ns/iter 0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer 207.1939888665737 ns/iter 298.4182025411428 ns/iter 0.69
Pointer_Walker_Schema_ISO_Language 2669506.1962025454 ns/iter 2509551.7045454844 ns/iter 1.06
Pointer_Maybe_Tracked_Deeply_Nested/0 1461281.2500000878 ns/iter 1524946.9814813181 ns/iter 0.96
Pointer_Maybe_Tracked_Deeply_Nested/1 1781738.542372989 ns/iter 2124584.353260819 ns/iter 0.84
Pointer_Position_Tracker_Get_Deeply_Nested 543.0217919999905 ns/iter 561.1483862166294 ns/iter 0.97
JSONPath_Descendant_Filter_Nested 1933.4159698300773 ns/iter 1671.0591868665515 ns/iter 1.16
URITemplateRouter_Create 26570.785431101413 ns/iter 30659.029846609912 ns/iter 0.87
URITemplateRouter_Match 246.55272857012403 ns/iter 239.83295870223972 ns/iter 1.03
URITemplateRouter_Match_BasePath 297.2482623245843 ns/iter 294.0133563691774 ns/iter 1.01
URITemplateRouterView_Restore 16656.17257688891 ns/iter 23350.170915701186 ns/iter 0.71
URITemplateRouterView_Match 217.1477890773149 ns/iter 195.4941511843697 ns/iter 1.11
URITemplateRouterView_Match_BasePath 222.27789935278818 ns/iter 235.54507963836622 ns/iter 0.94
URITemplateRouterView_Arguments 756.98831753735 ns/iter 880.126851930646 ns/iter 0.86
JSONL_Parse_Large 10475124.528736275 ns/iter 11356989.150684755 ns/iter 0.92
JSONL_Parse_Large_GZIP 12334912.57376865 ns/iter 16993481.07272685 ns/iter 0.73
JSONLD_Catalog_Annotation_List_Populate 780841.9801875002 ns/iter 950329.6712328031 ns/iter 0.82
JSONLD_Catalog_Materialize 3999674.79268348 ns/iter 4051995.4337899075 ns/iter 0.99
HTML_Build_Table_100000 60932579.199993595 ns/iter 79286100.00000162 ns/iter 0.77
HTML_Render_Table_100000 2612080.874999694 ns/iter 2949842.574545404 ns/iter 0.89
GZIP_Compress_ISO_Language_Set_3_Locations 38687442.16665871 ns/iter 32121856.750002563 ns/iter 1.20
GZIP_Decompress_ISO_Language_Set_3_Locations 5286251.65079286 ns/iter 5306950.10884363 ns/iter 1.00
GZIP_Compress_ISO_Language_Set_3_Schema 2267296.3091921103 ns/iter 1927703.082191802 ns/iter 1.18
GZIP_Decompress_ISO_Language_Set_3_Schema 385709.7888608165 ns/iter 396468.6489422147 ns/iter 0.97
JOSE_VerifySignature_RS256 34532.60744788226 ns/iter 50734.83749999923 ns/iter 0.68
JOSE_VerifySignature_ES512 1451785.989011014 ns/iter 1762661.0818858014 ns/iter 0.82

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 126b6b1 Previous: 14af3c9 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.9172395693012974 ns/iter 2.197695507760546 ns/iter 0.87
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.9106588523835855 ns/iter 2.1908878621091623 ns/iter 0.87
Regex_Period_Asterisk 1.9123259727396855 ns/iter 2.1889358652783857 ns/iter 0.87
Regex_Group_Period_Asterisk_Group 1.9093454646323937 ns/iter 2.1963866737495885 ns/iter 0.87
Regex_Period_Plus 3.0011151503759534 ns/iter 3.7346522730331966 ns/iter 0.80
Regex_Period 3.0009925490311593 ns/iter 3.735141283734974 ns/iter 0.80
Regex_Caret_Period_Plus_Dollar 3.000437334217255 ns/iter 3.7330258390611175 ns/iter 0.80
Regex_Caret_Group_Period_Plus_Group_Dollar 2.9988126646436073 ns/iter 3.7318558986632526 ns/iter 0.80
Regex_Caret_Period_Asterisk_Dollar 1.9094046761229888 ns/iter 2.1945471252796516 ns/iter 0.87
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.9102020021665629 ns/iter 2.1924794912036054 ns/iter 0.87
Regex_Caret_X_Hyphen 5.181561829685666 ns/iter 5.917476166725573 ns/iter 0.88
Regex_Period_Md_Dollar 20.87171421671074 ns/iter 27.235901299999963 ns/iter 0.77
Regex_Caret_Slash_Period_Asterisk 5.181538885409031 ns/iter 5.603130942030929 ns/iter 0.92
Regex_Caret_Period_Range_Dollar 1.9104060685347137 ns/iter 2.4933780322648604 ns/iter 0.77
Regex_Nested_Backtrack 30.11386516617878 ns/iter 38.74801301268206 ns/iter 0.78
JSON_Array_Of_Objects_Unique 369.02610676969636 ns/iter 454.19442497038284 ns/iter 0.81
JSON_Parse_1 3409.096050422129 ns/iter 4489.217355276233 ns/iter 0.76
JSON_Parse_Real 3977.479418626472 ns/iter 5234.268495211348 ns/iter 0.76
JSON_Parse_Decimal 5584.492198761409 ns/iter 7412.730211639928 ns/iter 0.75
JSON_Parse_Schema_ISO_Language 2677217.04230789 ns/iter 3276668.38139537 ns/iter 0.82
JSON_Parse_Integer 2943.37449555381 ns/iter 3581.4874020068846 ns/iter 0.82
JSON_Parse_String_NonSSO_Plain 2325.0733390381265 ns/iter 2968.7511276704845 ns/iter 0.78
JSON_Parse_String_SSO_Plain 2107.5988253136884 ns/iter 2578.125543594161 ns/iter 0.82
JSON_Parse_String_Escape_Heavy 10016.535283180485 ns/iter 11996.466823102437 ns/iter 0.83
JSON_Parse_Object_Short_Keys 6206.309841405056 ns/iter 7710.884951155973 ns/iter 0.80
JSON_Parse_Object_Scalar_Properties 3056.8443423630233 ns/iter 3938.7875486292182 ns/iter 0.78
JSON_Parse_Object_Array_Properties 4245.796606780203 ns/iter 5254.072804031125 ns/iter 0.81
JSON_Parse_Object_Object_Properties 4191.186889935664 ns/iter 5230.009668333109 ns/iter 0.80
JSON_Parse_Nested_Containers 26504.160222679366 ns/iter 34687.77802546332 ns/iter 0.76
JSON_From_String_Copy 8.862217229721718 ns/iter 10.466619525891186 ns/iter 0.85
JSON_From_String_Temporary 7.682167740163227 ns/iter 9.831966110524323 ns/iter 0.78
JSON_Number_To_Double 17.736590147350963 ns/iter 24.321136763402105 ns/iter 0.73
JSON_Object_At_Last_Key/8 3.1166498949822343 ns/iter 3.929540938382874 ns/iter 0.79
JSON_Object_At_Last_Key/32 10.42132794376119 ns/iter 12.248840262497577 ns/iter 0.85
JSON_Object_At_Last_Key/128 36.35091553068038 ns/iter 49.41360668201586 ns/iter 0.74
JSON_Object_At_Last_Key/512 281.42750261389324 ns/iter 383.57054374791244 ns/iter 0.73
JSON_Fast_Hash_Helm_Chart_Lock 44.8885287286172 ns/iter 54.47796433765453 ns/iter 0.82
JSON_Equality_Helm_Chart_Lock 119.19142864994939 ns/iter 156.82045291008436 ns/iter 0.76
JSON_Divisible_By_Decimal 200.26132610554788 ns/iter 253.60446522571615 ns/iter 0.79
JSON_String_Equal/10 4.367250865593694 ns/iter 5.918878570723844 ns/iter 0.74
JSON_String_Equal/100 5.201581750014488 ns/iter 6.543626380625635 ns/iter 0.79
JSON_String_Equal_Small_By_Perfect_Hash/10 0.8184367730707685 ns/iter 0.9350439029785635 ns/iter 0.88
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 9.631912286822642 ns/iter 10.593256598826779 ns/iter 0.91
JSON_String_Fast_Hash/10 1.6411607498045284 ns/iter 2.187621995627184 ns/iter 0.75
JSON_String_Fast_Hash/100 1.6383142760825495 ns/iter 2.180904074154459 ns/iter 0.75
JSON_String_Key_Hash/10 1.9104789944360456 ns/iter 2.1835010130472248 ns/iter 0.87
JSON_String_Key_Hash/100 5.998302617278918 ns/iter 6.540320864552615 ns/iter 0.92
JSON_Object_Defines_Miss_Same_Length 3.284163554888771 ns/iter 3.427684364955828 ns/iter 0.96
JSON_Object_Defines_Miss_Too_Small 2.4835317353105824 ns/iter 3.136080478671803 ns/iter 0.79
JSON_Object_Defines_Miss_Too_Large 2.279124136915266 ns/iter 2.9039909574798726 ns/iter 0.78
Pointer_Object_Traverse 23.76291164393968 ns/iter 28.699121962025934 ns/iter 0.83
Pointer_Object_Try_Traverse 25.38458998495147 ns/iter 30.87848140149915 ns/iter 0.82
Pointer_Push_Back_Pointer_To_Weak_Pointer 122.21148024316632 ns/iter 142.84069609882644 ns/iter 0.86
Pointer_Walker_Schema_ISO_Language 1188407.4675767978 ns/iter 1541081.947939194 ns/iter 0.77
Pointer_Maybe_Tracked_Deeply_Nested/0 998525.9857954984 ns/iter 1235916.948943673 ns/iter 0.81
Pointer_Maybe_Tracked_Deeply_Nested/1 1650791.786223279 ns/iter 1691990.3023809488 ns/iter 0.98
Pointer_Position_Tracker_Get_Deeply_Nested 542.7515525693564 ns/iter 636.1014747662543 ns/iter 0.85
JSONPath_Descendant_Filter_Nested 1210.0396901512265 ns/iter 1561.2969221108854 ns/iter 0.78
URITemplateRouter_Create 16121.224146981107 ns/iter 24470.061011019687 ns/iter 0.66
URITemplateRouter_Match 126.6974544337118 ns/iter 181.27541492905877 ns/iter 0.70
URITemplateRouter_Match_BasePath 153.08108765134725 ns/iter 205.64268616841824 ns/iter 0.74
URITemplateRouterView_Restore 7634.416734527817 ns/iter 8241.325378077185 ns/iter 0.93
URITemplateRouterView_Match 107.55364761716856 ns/iter 141.23670978171765 ns/iter 0.76
URITemplateRouterView_Match_BasePath 126.05461399439903 ns/iter 162.93331093342508 ns/iter 0.77
URITemplateRouterView_Arguments 356.05906395519446 ns/iter 431.0777122446355 ns/iter 0.83
JSONL_Parse_Large 7002059.400000462 ns/iter 9001911.74025991 ns/iter 0.78
JSONL_Parse_Large_GZIP 8257040.476190506 ns/iter 10544001.772727238 ns/iter 0.78
JSONLD_Catalog_Annotation_List_Populate 489074.6692307676 ns/iter 592003.9813874618 ns/iter 0.83
JSONLD_Catalog_Materialize 2654850.896551684 ns/iter 3444745.3921569935 ns/iter 0.77
HTML_Build_Table_100000 49629241.846153386 ns/iter 56703766.36363595 ns/iter 0.88
HTML_Render_Table_100000 1879887.2195122193 ns/iter 1780626.7729591995 ns/iter 1.06
GZIP_Compress_ISO_Language_Set_3_Locations 27745615.720000386 ns/iter 33485080.857144028 ns/iter 0.83
GZIP_Decompress_ISO_Language_Set_3_Locations 3312804.582938517 ns/iter 4085665.3294119546 ns/iter 0.81
GZIP_Compress_ISO_Language_Set_3_Schema 1654250.219858183 ns/iter 1888117.3234501265 ns/iter 0.88
GZIP_Decompress_ISO_Language_Set_3_Schema 214449.9641982765 ns/iter 351760.28064842854 ns/iter 0.61
JOSE_VerifySignature_RS256 49758.97102377784 ns/iter 56762.014909649624 ns/iter 0.88
JOSE_VerifySignature_ES512 2198975.3427672 ns/iter 2422067.820689649 ns/iter 0.91

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 126b6b1 Previous: 14af3c9 Ratio
JOSE_VerifySignature_RS256 22183.598491542478 ns/iter 22492.413542926843 ns/iter 0.99
JOSE_VerifySignature_ES512 575495.1446179177 ns/iter 576199.8421052651 ns/iter 1.00
GZIP_Compress_ISO_Language_Set_3_Locations 37214596.5789478 ns/iter 36535172.210524015 ns/iter 1.02
GZIP_Decompress_ISO_Language_Set_3_Locations 4181744.6024094396 ns/iter 4194942.420118159 ns/iter 1.00
GZIP_Compress_ISO_Language_Set_3_Schema 2043517.4606415145 ns/iter 2039730.8629737177 ns/iter 1.00
GZIP_Decompress_ISO_Language_Set_3_Schema 382259.90864599793 ns/iter 376837.6616379241 ns/iter 1.01
HTML_Build_Table_100000 55031173.41667026 ns/iter 54797603.50000144 ns/iter 1.00
HTML_Render_Table_100000 1878864.6775067847 ns/iter 1931977.3808218725 ns/iter 0.97
JSONLD_Catalog_Annotation_List_Populate 679724.3449612843 ns/iter 677947.0784124386 ns/iter 1.00
JSONLD_Catalog_Materialize 3504708.7989950175 ns/iter 3461904.069306929 ns/iter 1.01
JSONL_Parse_Large 9696119.944444425 ns/iter 9837509.957746122 ns/iter 0.99
JSONL_Parse_Large_GZIP 11078467.85714267 ns/iter 11243139.555555595 ns/iter 0.99
URITemplateRouter_Create 21140.85642399818 ns/iter 21116.45126282517 ns/iter 1.00
URITemplateRouter_Match 153.98021492038632 ns/iter 157.32629472068137 ns/iter 0.98
URITemplateRouter_Match_BasePath 181.83478534826708 ns/iter 184.55023994813126 ns/iter 0.99
URITemplateRouterView_Restore 8406.841613426115 ns/iter 8404.241598525603 ns/iter 1.00
URITemplateRouterView_Match 122.34690764350262 ns/iter 125.91355719374549 ns/iter 0.97
URITemplateRouterView_Match_BasePath 144.68262569014777 ns/iter 148.40974650980633 ns/iter 0.97
URITemplateRouterView_Arguments 467.59747382626085 ns/iter 479.79529860496217 ns/iter 0.97
JSONPath_Descendant_Filter_Nested 1614.3092974805058 ns/iter 1623.4834386128223 ns/iter 0.99
Pointer_Object_Traverse 23.026474186624377 ns/iter 23.17452531297153 ns/iter 0.99
Pointer_Object_Try_Traverse 25.860889884463266 ns/iter 25.883496628399513 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 127.01932590856131 ns/iter 150.2696033921338 ns/iter 0.85
Pointer_Walker_Schema_ISO_Language 1395847.5410822027 ns/iter 1417382.2815734507 ns/iter 0.98
Pointer_Maybe_Tracked_Deeply_Nested/0 1208365.864494028 ns/iter 1203314.0118845322 ns/iter 1.00
Pointer_Maybe_Tracked_Deeply_Nested/1 1689761.588516759 ns/iter 1678007.4216867487 ns/iter 1.01
Pointer_Position_Tracker_Get_Deeply_Nested 596.5947345866406 ns/iter 602.4570550437682 ns/iter 0.99
JSON_Array_Of_Objects_Unique 466.52080530865396 ns/iter 466.7133616449632 ns/iter 1.00
JSON_Parse_1 5203.524952509685 ns/iter 5254.639108661292 ns/iter 0.99
JSON_Parse_Real 5565.601657014453 ns/iter 5891.00247260685 ns/iter 0.94
JSON_Parse_Decimal 10269.655267561691 ns/iter 10463.636461382419 ns/iter 0.98
JSON_Parse_Schema_ISO_Language 3624152.922279826 ns/iter 3600276.5641027372 ns/iter 1.01
JSON_Parse_Integer 3737.094160236403 ns/iter 3797.0194671075237 ns/iter 0.98
JSON_Parse_String_NonSSO_Plain 3272.423819928086 ns/iter 3270.3140847503614 ns/iter 1.00
JSON_Parse_String_SSO_Plain 3064.532222557994 ns/iter 2978.19528673973 ns/iter 1.03
JSON_Parse_String_Escape_Heavy 16730.9567942592 ns/iter 16667.033957168005 ns/iter 1.00
JSON_Parse_Object_Short_Keys 8423.859004596266 ns/iter 8697.528580298334 ns/iter 0.97
JSON_Parse_Object_Scalar_Properties 4298.377168517937 ns/iter 4290.920596677393 ns/iter 1.00
JSON_Parse_Object_Array_Properties 6426.070915421943 ns/iter 6490.7300817374135 ns/iter 0.99
JSON_Parse_Object_Object_Properties 6524.631638807889 ns/iter 6547.8330844365655 ns/iter 1.00
JSON_Parse_Nested_Containers 38877.90496304082 ns/iter 39082.81979131842 ns/iter 0.99
JSON_From_String_Copy 8.532424568059465 ns/iter 8.530152909558716 ns/iter 1.00
JSON_From_String_Temporary 7.236637522601338 ns/iter 7.432116293700513 ns/iter 0.97
JSON_Number_To_Double 21.806698733945197 ns/iter 22.141107854976863 ns/iter 0.98
JSON_Object_At_Last_Key/8 5.616109092807761 ns/iter 5.6118870046534575 ns/iter 1.00
JSON_Object_At_Last_Key/32 21.548903139683393 ns/iter 21.573092897187546 ns/iter 1.00
JSON_Object_At_Last_Key/128 89.49587749537834 ns/iter 87.84617533922084 ns/iter 1.02
JSON_Object_At_Last_Key/512 393.7685875554798 ns/iter 392.9513225471613 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 87.96083162065665 ns/iter 87.5871722643692 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 148.7692896814384 ns/iter 147.816200597061 ns/iter 1.01
JSON_Divisible_By_Decimal 259.7913195726021 ns/iter 259.9211277288661 ns/iter 1.00
JSON_String_Equal/10 5.414829612823997 ns/iter 5.413802686553402 ns/iter 1.00
JSON_String_Equal/100 6.040295602312019 ns/iter 6.053763141149578 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 0.750192804735542 ns/iter 0.7487961632102975 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 25.199349221012348 ns/iter 25.189277731158565 ns/iter 1.00
JSON_String_Fast_Hash/10 3.2247001011245673 ns/iter 3.1515925122869084 ns/iter 1.02
JSON_String_Fast_Hash/100 3.152596227512074 ns/iter 3.151445729390428 ns/iter 1.00
JSON_String_Key_Hash/10 1.2467662005774471 ns/iter 1.2469169070528048 ns/iter 1.00
JSON_String_Key_Hash/100 12.451732629931271 ns/iter 12.442195274444673 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 3.1158911280761905 ns/iter 3.112552362001312 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.431205783481306 ns/iter 3.424822354054035 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.1146946355907583 ns/iter 3.1151134334775845 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 0.6225870925468308 ns/iter 0.622476970901485 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 0.6252959994713155 ns/iter 0.6226423562171957 ns/iter 1.00
Regex_Period_Asterisk 0.6228926328272564 ns/iter 0.6231748211671304 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 0.6229070244963992 ns/iter 0.6246405285579544 ns/iter 1.00
Regex_Period_Plus 0.6227491091017004 ns/iter 0.6228027953724716 ns/iter 1.00
Regex_Period 0.6233107265739259 ns/iter 0.6225874471965546 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 0.6298033321593314 ns/iter 0.6240272818940259 ns/iter 1.01
Regex_Caret_Group_Period_Plus_Group_Dollar 0.6234054406457842 ns/iter 0.623269799299602 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 0.6239805726708656 ns/iter 0.6228860759876728 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 0.6227642021946432 ns/iter 0.6226476856863471 ns/iter 1.00
Regex_Caret_X_Hyphen 4.081348646759611 ns/iter 4.051141927822434 ns/iter 1.01
Regex_Period_Md_Dollar 26.687466768838373 ns/iter 35.93902021009316 ns/iter 0.74
Regex_Caret_Slash_Period_Asterisk 4.361934038432194 ns/iter 4.369105033718798 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 1.2466961215000913 ns/iter 1.2510926497569743 ns/iter 1.00
Regex_Nested_Backtrack 36.571942289074855 ns/iter 37.72795756041321 ns/iter 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 126b6b1 Previous: c9b8470 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 5.025269000000208 ns/iter 2.294145533153671 ns/iter 2.19
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 4.969656000000668 ns/iter 2.310204908135855 ns/iter 2.15
Regex_Period_Asterisk 4.969269642856489 ns/iter 2.2688403125000534 ns/iter 2.19
Regex_Group_Period_Asterisk_Group 5.065366999999696 ns/iter 2.269553568895599 ns/iter 2.23
Regex_Period_Plus 4.676829341194883 ns/iter 2.327446202759638 ns/iter 2.01
Regex_Period 4.603188626345269 ns/iter 2.293957499999877 ns/iter 2.01
Regex_Caret_Period_Plus_Dollar 4.674279921148588 ns/iter 2.2824763367383136 ns/iter 2.05
Regex_Caret_Group_Period_Plus_Group_Dollar 4.614938292238699 ns/iter 2.3043875000000824 ns/iter 2.00
Regex_Caret_Period_Asterisk_Dollar 5.253150000000915 ns/iter 2.2769183010301797 ns/iter 2.31
Regex_Caret_Group_Period_Asterisk_Group_Dollar 5.128875999998854 ns/iter 2.2821046849530005 ns/iter 2.25
Regex_Caret_X_Hyphen 7.971047991071702 ns/iter 6.411056249999905 ns/iter 1.24
Regex_Period_Md_Dollar 54.55389285714319 ns/iter 25.793561333438245 ns/iter 2.12
Regex_Caret_Slash_Period_Asterisk 7.512257812499914 ns/iter 5.933291071428418 ns/iter 1.27
Regex_Caret_Period_Range_Dollar 5.329745999999886 ns/iter 2.7708618725259466 ns/iter 1.92
Regex_Nested_Backtrack 80.9378459821478 ns/iter 36.138185025860885 ns/iter 2.24
JSON_Array_Of_Objects_Unique 824.2956473214491 ns/iter 451.9496021563581 ns/iter 1.82
JSON_Parse_1 9482.854540827311 ns/iter 7542.007848179261 ns/iter 1.26
JSON_Parse_Real 18020.360003214853 ns/iter 10369.826562500073 ns/iter 1.74
JSON_Parse_Decimal 11423.896875001561 ns/iter 8209.168526785199 ns/iter 1.39
JSON_Parse_Schema_ISO_Language 8061006.666664778 ns/iter 7276925.555555005 ns/iter 1.11
JSON_Parse_Integer 5949.449107142917 ns/iter 4085.400561784804 ns/iter 1.46
JSON_Parse_String_NonSSO_Plain 8027.922991072753 ns/iter 5985.817857143059 ns/iter 1.34
JSON_Parse_String_SSO_Plain 3864.210599624607 ns/iter 2643.25428571429 ns/iter 1.46
JSON_Parse_String_Escape_Heavy 22112.93437500217 ns/iter 20376.66125007283 ns/iter 1.09
JSON_Parse_Object_Short_Keys 12964.221428571169 ns/iter 8850.878348214408 ns/iter 1.46
JSON_Parse_Object_Scalar_Properties 6713.736607143313 ns/iter 4563.294114495525 ns/iter 1.47
JSON_Parse_Object_Array_Properties 11659.346428574832 ns/iter 8297.639508928001 ns/iter 1.41
JSON_Parse_Object_Object_Properties 11898.45781249943 ns/iter 8537.35385109891 ns/iter 1.39
JSON_Parse_Nested_Containers 84045.46672025825 ns/iter 58600.64285713966 ns/iter 1.43
JSON_From_String_Copy 63.02298999999039 ns/iter 43.82056875000018 ns/iter 1.44
JSON_From_String_Temporary 83.61645162426771 ns/iter 51.50982000000113 ns/iter 1.62
JSON_Number_To_Double 144.42985714282486 ns/iter 77.85854116703119 ns/iter 1.86
JSON_Object_At_Last_Key/8 7.3233437499986564 ns/iter 7.035142857143255 ns/iter 1.04
JSON_Object_At_Last_Key/32 25.148421431222303 ns/iter 16.720160714284965 ns/iter 1.50
JSON_Object_At_Last_Key/128 94.41003348215864 ns/iter 82.44693080357024 ns/iter 1.15
JSON_Object_At_Last_Key/512 440.84650000002057 ns/iter 288.8158717839384 ns/iter 1.53
JSON_Fast_Hash_Helm_Chart_Lock 130.65114595306866 ns/iter 67.7733124999997 ns/iter 1.93
JSON_Equality_Helm_Chart_Lock 204.76258460884193 ns/iter 184.0261503594691 ns/iter 1.11
JSON_Divisible_By_Decimal 336.07374001153335 ns/iter 232.5015312500156 ns/iter 1.45
JSON_String_Equal/10 9.948832991300266 ns/iter 8.668123883928759 ns/iter 1.15
JSON_String_Equal/100 11.706979687499341 ns/iter 10.815426562500008 ns/iter 1.08
JSON_String_Equal_Small_By_Perfect_Hash/10 2.155509062500016 ns/iter 1.15935035714289 ns/iter 1.86
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 13.858712214918702 ns/iter 8.915298174485088 ns/iter 1.55
JSON_String_Fast_Hash/10 6.4112812499997425 ns/iter 3.380070663606858 ns/iter 1.90
JSON_String_Fast_Hash/100 6.431801785715103 ns/iter 3.356648520791665 ns/iter 1.92
JSON_String_Key_Hash/10 5.008067999999639 ns/iter 3.1723312500001755 ns/iter 1.58
JSON_String_Key_Hash/100 11.119920312498978 ns/iter 7.665996651785737 ns/iter 1.45
JSON_Object_Defines_Miss_Same_Length 4.67037121578353 ns/iter 4.330820502758943 ns/iter 1.08
JSON_Object_Defines_Miss_Too_Small 4.663267857143946 ns/iter 4.777619876662069 ns/iter 0.98
JSON_Object_Defines_Miss_Too_Large 4.643875000001327 ns/iter 4.6249898993584315 ns/iter 1.00
Pointer_Object_Traverse 66.4170803571348 ns/iter 35.30757699570695 ns/iter 1.88
Pointer_Object_Try_Traverse 68.08956249999807 ns/iter 38.42213727678663 ns/iter 1.77
Pointer_Push_Back_Pointer_To_Weak_Pointer 156.43558035713616 ns/iter 151.19256696428505 ns/iter 1.03
Pointer_Walker_Schema_ISO_Language 11667128.125001369 ns/iter 9490530.666666927 ns/iter 1.23
Pointer_Maybe_Tracked_Deeply_Nested/0 2479334.090909643 ns/iter 1934155.1839465408 ns/iter 1.28
Pointer_Maybe_Tracked_Deeply_Nested/1 3680861.5384614267 ns/iter 3404242.7230048534 ns/iter 1.08
Pointer_Position_Tracker_Get_Deeply_Nested 579.617745535594 ns/iter 488.8754464285431 ns/iter 1.19
JSONPath_Descendant_Filter_Nested 2517.587142857077 ns/iter 1572.875000000045 ns/iter 1.60
URITemplateRouter_Create 39085.81453903225 ns/iter 33200.63282238764 ns/iter 1.18
URITemplateRouter_Match 219.35287499999845 ns/iter 229.06982934489957 ns/iter 0.96
URITemplateRouter_Match_BasePath 245.60921428571547 ns/iter 273.7206550768325 ns/iter 0.90
URITemplateRouterView_Restore 25848.885714286294 ns/iter 16410.589285714548 ns/iter 1.58
URITemplateRouterView_Match 174.66625666667713 ns/iter 162.6219642857204 ns/iter 1.07
URITemplateRouterView_Match_BasePath 199.20821421501532 ns/iter 184.1960789460763 ns/iter 1.08
URITemplateRouterView_Arguments 600.0666964285172 ns/iter 405.0112731044407 ns/iter 1.48
JSONL_Parse_Large 33336929.999995846 ns/iter 30751112.499999065 ns/iter 1.08
JSONL_Parse_Large_GZIP 33839199.999999896 ns/iter 29870445.45454606 ns/iter 1.13
JSONLD_Catalog_Annotation_List_Populate 3234400.469484317 ns/iter 2638596.9696969003 ns/iter 1.23
JSONLD_Catalog_Materialize 8792542.66666673 ns/iter 6011983.035714406 ns/iter 1.46
HTML_Build_Table_100000 95474214.28572176 ns/iter 91933557.14286003 ns/iter 1.04
HTML_Render_Table_100000 8097309.333334124 ns/iter 11424867.187500354 ns/iter 0.71
GZIP_Compress_ISO_Language_Set_3_Locations 37785772.22221378 ns/iter 28376068.000000034 ns/iter 1.33
GZIP_Decompress_ISO_Language_Set_3_Locations 10490889.062499065 ns/iter 11176290.624999475 ns/iter 0.94
GZIP_Compress_ISO_Language_Set_3_Schema 2313739.799331759 ns/iter 1794558.9680589957 ns/iter 1.29
GZIP_Decompress_ISO_Language_Set_3_Schema 600796.9642857753 ns/iter 599032.678571427 ns/iter 1.00
JOSE_VerifySignature_RS256 23872.49807479446 ns/iter 17276.867925455343 ns/iter 1.38
JOSE_VerifySignature_ES512 1583424.1071429136 ns/iter 925746.3186077563 ns/iter 1.71

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti force-pushed the clang-tidy-stronger branch from b7b0c27 to 3c377a9 Compare September 2, 2026 18:49
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti marked this pull request as ready for review September 2, 2026 20:19
@jviotti jviotti changed the title [WIP] Add many more clang-tidy stricter checks Add many more clang-tidy stricter checks Sep 2, 2026
@augmentcode

augmentcode Bot commented Sep 2, 2026

Copy link
Copy Markdown

This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread test/json/json_value_test.cc Outdated
Comment thread cmake/common/clang-tidy.cmake Outdated
Comment thread cmake/common/clang-tidy.json
Comment thread test/uritemplate/uritemplate_suite.cc Outdated
Comment thread test/json/json_real_test.cc
Comment thread cmake/common/clang-tidy.json Outdated
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit 4862283 into main Sep 2, 2026
13 checks passed
@jviotti
jviotti deleted the clang-tidy-stronger branch September 2, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant