Adopt C++23

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[cubic-dev-ai]

No issues found across 60 files

[augmentcode]

🤖 Augment PR Summary

Summary: Updates the vendored sourcemeta/core subtree to commit 7e57b205…, bringing in C++23 adoption and several new/updated utilities.

Changes:

• Bumps Core’s default C++ standard to C++23 and modernizes implementations to use C++23 APIs (e.g., std::ranges algorithms, std::to_chars/from_chars, std::unreachable, std::string::resize_and_overwrite).
• Adds a new Core ip component with IPv4/IPv6 validators and integrates it into Core’s CMake options/config export.
• Updates URI helpers to use the new IP validation (adds URI::is_ipv4(), tightens is_ipv6(), tracks IP-literal hosts for correct recomposition).
• Adds std::formatter specializations for Core JSON and vocabularies to support std::format.
• Refactors JSON/YAML/regex parsing and stringification paths to avoid locale-dependent conversions and reduce exception-based parsing.
• Extends the URI template router to store per-route typed arguments and bumps the serialized router format version to v2, including read/write support.

Technical Notes: The update touches build/export wiring (new component + linkage), and introduces a new on-disk router format; downstream consumers may need to account for transitive dependencies and router version compatibility.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

vendor/core/src/core/uri/CMakeLists.txt:10 — If BUILD_SHARED_LIBS=OFF, linking sourcemeta_core_uri to sourcemeta::core::ip as PRIVATE won’t propagate the dependency to consumers and can cause unresolved symbols (e.g., URI::is_ipv4() / URI::is_ipv6()). Consider whether this should be transitive to match config.cmake.in including sourcemeta_core_ip.cmake when the uri component is requested.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

vendor/core/src/core/uritemplate/include/sourcemeta/core/uritemplate_router.h:79 — add(..., arguments) stores Argument entries as std::string_view (and may store std::string_view values inside the variant), so callers now need to ensure argument name/value lifetimes outlive the router, not just uri_template. Without that, save()/arguments() can end up reading dangling views.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}