Skip to content

Upgrade Core and Blaze to the latest versions#703

Merged
jviotti merged 3 commits intomainfrom
inspect-fix
Apr 1, 2026
Merged

Upgrade Core and Blaze to the latest versions#703
jviotti merged 3 commits intomainfrom
inspect-fix

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Apr 1, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 1, 2026

🤖 Augment PR Summary

Summary: This PR bumps the vendored core and blaze dependencies to newer revisions.

Changes:

  • Updates dependency SHAs in DEPENDENCIES and vendor/blaze/DEPENDENCIES
  • Changes inspect --json frame serialization to emit JSON Pointer values (pointer, relativePointer, origin, parent) as strings (or null) instead of arrays
  • Updates inspect golden-output shell tests to match the new JSON shape
  • Improves numeric divisibility checks by adding Decimal::strict_from(double) and using it in JSON::divisible_by to avoid IEEE-754 precision artifacts

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

std::array<char, 64> buffer{};
const auto result{
std::to_chars(buffer.data(), buffer.data() + buffer.size(), value)};
assert(result.ec == std::errc{});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decimal::strict_from relies on assert(result.ec == std::errc{}), so in release builds a std::to_chars failure (e.g., buffer too small) could silently create an invalid/empty string_view and then throw from Decimal(std::string_view) or produce incorrect values. Consider making the to_chars error handling explicit since callers (e.g., JSON::divisible_by) are likely not expecting exceptions here.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/test.yml">

<violation number="1" location=".github/workflows/test.yml:71">
P2: Install `gcc-14` in the WSL setup to match `CC=gcc-14`; otherwise the compiler binary won’t exist and the build will fail.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

with:
distribution: Ubuntu-24.04
additional-packages: cmake build-essential shellcheck pipx zsh jq bindfs
additional-packages: cmake build-essential g++-14 shellcheck pipx zsh jq bindfs
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Install gcc-14 in the WSL setup to match CC=gcc-14; otherwise the compiler binary won’t exist and the build will fail.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/test.yml, line 71:

<comment>Install `gcc-14` in the WSL setup to match `CC=gcc-14`; otherwise the compiler binary won’t exist and the build will fail.</comment>

<file context>
@@ -66,7 +68,7 @@ jobs:
         with:
           distribution: Ubuntu-24.04
-          additional-packages: cmake build-essential shellcheck pipx zsh jq bindfs
+          additional-packages: cmake build-essential g++-14 shellcheck pipx zsh jq bindfs
           wsl-version: 2
 
</file context>
Fix with Cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit b6388f9 into main Apr 1, 2026
14 checks passed
@jviotti jviotti deleted the inspect-fix branch April 1, 2026 18:35
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Apr 2, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | minor | `v14.14.2` → `v14.17.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary>

### [`v14.17.1`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.17.1)

[Compare Source](sourcemeta/jsonschema@v14.17.0...v14.17.1)

#### What's Changed

- Statically link the C++ standard library on the Linux binaries for extra distro compatibility by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;701](sourcemeta/jsonschema#701)
- Fix a case of rounding error on `multipleOf` with negative exponents of 10 by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;703](sourcemeta/jsonschema#703)

**Full Changelog**: <sourcemeta/jsonschema@v14.17.0...v14.17.1>

### [`v14.17.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.17.0)

[Compare Source](sourcemeta/jsonschema@v14.16.2...v14.17.0)

#### What's Changed

- New linter rules: `forbid_empty_enum` and `invalid_external_ref` by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;695](sourcemeta/jsonschema#695)

**Full Changelog**: <sourcemeta/jsonschema@v14.16.2...v14.17.0>

### [`v14.16.2`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.16.2)

[Compare Source](sourcemeta/jsonschema@v14.16.1...v14.16.2)

#### What's Changed

- Fix a few subtle URI unescaping RFC compliant issues by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;693](sourcemeta/jsonschema#693)
- Fix `lint --fix` affecting rounding of some real numbers by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;694](sourcemeta/jsonschema#694)

**Full Changelog**: <sourcemeta/jsonschema@v14.16.1...v14.16.2>

### [`v14.16.1`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.16.1)

[Compare Source](sourcemeta/jsonschema@v14.16.0...v14.16.1)

#### What's Changed

- Avoid tracking instance positions on `--fast` mode by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;689](sourcemeta/jsonschema#689)
- Speed up parsing of big instances by orders of magnitude by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;691](sourcemeta/jsonschema#691) and [#&#8203;688](sourcemeta/jsonschema#688)

**Full Changelog**: <sourcemeta/jsonschema@v14.16.0...v14.16.1>

### [`v14.16.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.16.0)

[Compare Source](sourcemeta/jsonschema@v14.15.0...v14.16.0)

#### What's Changed

- Add linter rules to catch `enum` + `const` by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;686](sourcemeta/jsonschema#686)
- Make it clear we don't support 2020-12 `format-assertion` yet by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;687](sourcemeta/jsonschema#687)

**Full Changelog**: <sourcemeta/jsonschema@v14.15.0...v14.16.0>

### [`v14.15.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.15.0)

[Compare Source](sourcemeta/jsonschema@v14.14.2...v14.15.0)

#### What's Changed

- Support standard input through `-` in all commands by [@&#8203;Vaibhav701161](https://github.com/Vaibhav701161) in [#&#8203;661](sourcemeta/jsonschema#661)

**Full Changelog**: <sourcemeta/jsonschema@v14.14.2...v14.15.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My45Mi4xIiwidXBkYXRlZEluVmVyIjoiNDMuMTAyLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCIsImF1dG9tYXRpb246Ym90LWF1dGhvcmVkIiwiZGVwZW5kZW5jeS10eXBlOjptaW5vciJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant