Upgrade Core and Blaze - #829
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
|
This pull request is too large for Augment to review. The PR exceeds the maximum size limit of 75000 tokens (approximately 300000 characters) for automated code review. Please consider breaking this PR into smaller, more focused changes. |
There was a problem hiding this comment.
1 issue found across 160 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/command_metaschema.cc">
<violation number="1" location="src/command_metaschema.cc:28">
P2: The new `resolve_metaschema` helper duplicates the body of the library function `sourcemeta::blaze::metaschema` (vendor/blaze foundation.cc) line-for-line: embedded-metaschema precedence, resolver fallback, and the relative/absolute resolution error split are all identical, and the one part it omits (unknown-dialect check) is already handled by the caller's `dialect.empty()` check. Keep the single canonical call instead of re-implementing it, so future changes to blaze's resolution logic (embedded handling, error types) propagate here and the code can't drift.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| namespace { | ||
|
|
||
| auto resolve_metaschema(const sourcemeta::core::JSON &schema, |
There was a problem hiding this comment.
P2: The new resolve_metaschema helper duplicates the body of the library function sourcemeta::blaze::metaschema (vendor/blaze foundation.cc) line-for-line: embedded-metaschema precedence, resolver fallback, and the relative/absolute resolution error split are all identical, and the one part it omits (unknown-dialect check) is already handled by the caller's dialect.empty() check. Keep the single canonical call instead of re-implementing it, so future changes to blaze's resolution logic (embedded handling, error types) propagate here and the code can't drift.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/command_metaschema.cc, line 28:
<comment>The new `resolve_metaschema` helper duplicates the body of the library function `sourcemeta::blaze::metaschema` (vendor/blaze foundation.cc) line-for-line: embedded-metaschema precedence, resolver fallback, and the relative/absolute resolution error split are all identical, and the one part it omits (unknown-dialect check) is already handled by the caller's `dialect.empty()` check. Keep the single canonical call instead of re-implementing it, so future changes to blaze's resolution logic (embedded handling, error types) propagate here and the code can't drift.</comment>
<file context>
@@ -21,6 +23,36 @@
+namespace {
+
+auto resolve_metaschema(const sourcemeta::core::JSON &schema,
+ const std::string_view dialect,
+ const sourcemeta::blaze::SchemaResolver &resolver)
</file context>
Signed-off-by: Juan Cruz Viotti jv@jviotti.com