Skip to content

Upgrade Core and Blaze - #829

Merged
jviotti merged 1 commit into
mainfrom
blaze-frame-1
Aug 26, 2026
Merged

Upgrade Core and Blaze#829
jviotti merged 1 commit into
mainfrom
blaze-frame-1

Conversation

@jviotti

@jviotti jviotti commented Aug 26, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Aug 26, 2026

Copy link
Copy Markdown

This pull request is too large for Augment to review. The PR exceeds the maximum size limit of 75000 tokens (approximately 300000 characters) for automated code review. Please consider breaking this PR into smaller, more focused changes.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 160 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/command_metaschema.cc">

<violation number="1" location="src/command_metaschema.cc:28">
P2: The new `resolve_metaschema` helper duplicates the body of the library function `sourcemeta::blaze::metaschema` (vendor/blaze foundation.cc) line-for-line: embedded-metaschema precedence, resolver fallback, and the relative/absolute resolution error split are all identical, and the one part it omits (unknown-dialect check) is already handled by the caller's `dialect.empty()` check. Keep the single canonical call instead of re-implementing it, so future changes to blaze's resolution logic (embedded handling, error types) propagate here and the code can't drift.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/command_metaschema.cc

namespace {

auto resolve_metaschema(const sourcemeta::core::JSON &schema,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The new resolve_metaschema helper duplicates the body of the library function sourcemeta::blaze::metaschema (vendor/blaze foundation.cc) line-for-line: embedded-metaschema precedence, resolver fallback, and the relative/absolute resolution error split are all identical, and the one part it omits (unknown-dialect check) is already handled by the caller's dialect.empty() check. Keep the single canonical call instead of re-implementing it, so future changes to blaze's resolution logic (embedded handling, error types) propagate here and the code can't drift.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/command_metaschema.cc, line 28:

<comment>The new `resolve_metaschema` helper duplicates the body of the library function `sourcemeta::blaze::metaschema` (vendor/blaze foundation.cc) line-for-line: embedded-metaschema precedence, resolver fallback, and the relative/absolute resolution error split are all identical, and the one part it omits (unknown-dialect check) is already handled by the caller's `dialect.empty()` check. Keep the single canonical call instead of re-implementing it, so future changes to blaze's resolution logic (embedded handling, error types) propagate here and the code can't drift.</comment>

<file context>
@@ -21,6 +23,36 @@
 
+namespace {
+
+auto resolve_metaschema(const sourcemeta::core::JSON &schema,
+                        const std::string_view dialect,
+                        const sourcemeta::blaze::SchemaResolver &resolver)
</file context>

@jviotti
jviotti merged commit f6ac124 into main Aug 26, 2026
16 checks passed
@jviotti
jviotti deleted the blaze-frame-1 branch August 26, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant