Skip to content

Add Playwright tests around SSO#1147

Merged
jviotti merged 2 commits into
mainfrom
sso-playwright
Jul 18, 2026
Merged

Add Playwright tests around SSO#1147
jviotti merged 2 commits into
mainfrom
sso-playwright

Conversation

@jviotti

@jviotti jviotti commented Jul 18, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Jul 18, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR expands the enterprise SSO E2E coverage by adding a Playwright suite and adjusts the login referrer policy so interactive OIDC logins can return users to the originally denied path.

Changes:

  • Added a new Playwright test suite for the enterprise/e2e/auth-sso sandbox covering public browsing, gated-folder login UX, deep-link return, and logout re-gating.
  • Introduced a dedicated playwright.config.js for the SSO suite, including a host resolver rule so the browser can follow Keycloak redirects to keycloak:8080.
  • Relaxed the login page referrer policy from strict-origin-when-cross-origin to same-origin so /self/v1/auth/login/<provider> can infer the return target via Referer.
  • Updated the SSO Hurl assertion to match the new Referrer-Policy header value.
  • Made html::make_head() accept a configurable referrer policy (defaulting to no-referrer) and used same-origin for the login page.

Technical Notes: The tests assume the Keycloak realm/users from the sandbox and that the browser can resolve keycloak to localhost for the OIDC redirect chain.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread enterprise/e2e/auth-sso/playwright/playwright.config.js Outdated
Comment thread src/web/page.h Outdated
Comment thread src/router/router.cc Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (community)

Details
Benchmark suite Current: ca75776 Previous: 83474e0 Ratio
Add one schema (0 existing) 343 ms 355 ms 0.97
Add one schema (100 existing) 29 ms 30 ms 0.97
Add one schema (1000 existing) 85 ms 92 ms 0.92
Add one schema (10000 existing) 722 ms 763 ms 0.95
Update one schema (1 existing) 21 ms 22 ms 0.95
Update one schema (101 existing) 29 ms 31 ms 0.94
Update one schema (1001 existing) 84 ms 96 ms 0.88
Update one schema (10001 existing) 712 ms 773 ms 0.92
Cached rebuild (1 existing) 7 ms 8 ms 0.88
Cached rebuild (101 existing) 9 ms 9 ms 1
Cached rebuild (1001 existing) 29 ms 31 ms 0.94
Cached rebuild (10001 existing) 252 ms 262 ms 0.96
Index 100 schemas 658 ms 693 ms 0.95
Index 1000 schemas 1323 ms 1550 ms 0.85
Index 10000 schemas 14006 ms 14077 ms 0.99
Index 10000 schemas (custom meta-schema) 16639 ms 17102 ms 0.97
Index 10000 schemas ($ref fan-out) 16608 ms 17276 ms 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Index (enterprise)

Details
Benchmark suite Current: ca75776 Previous: 83474e0 Ratio
Add one schema (0 existing) 406 ms 416 ms 0.98
Add one schema (100 existing) 109 ms 105 ms 1.04
Add one schema (1000 existing) 161 ms 158 ms 1.02
Add one schema (10000 existing) 830 ms 783 ms 1.06
Update one schema (1 existing) 97 ms 97 ms 1
Update one schema (101 existing) 103 ms 103 ms 1
Update one schema (1001 existing) 159 ms 160 ms 0.99
Update one schema (10001 existing) 783 ms 770 ms 1.02
Cached rebuild (1 existing) 8 ms 8 ms 1
Cached rebuild (101 existing) 11 ms 11 ms 1
Cached rebuild (1001 existing) 31 ms 31 ms 1
Cached rebuild (10001 existing) 252 ms 258 ms 0.98
Index 100 schemas 716 ms 748 ms 0.96
Index 1000 schemas 1596 ms 1397 ms 1.14
Index 10000 schemas 13979 ms 13931 ms 1.00
Index 10000 schemas (custom meta-schema) 17082 ms 16778 ms 1.02
Index 10000 schemas ($ref fan-out) 17061 ms 17060 ms 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit 43e17de into main Jul 18, 2026
5 checks passed
@jviotti
jviotti deleted the sso-playwright branch July 18, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant