65850 migrate windows implementation#2
Merged
juandausa merged 16 commits into65835-migrate-windows-implementation-to-dartfrom Sep 19, 2022
Merged
Conversation
…itle. Remove warnings.
…t_file_selector_api.
#65847 Migrate open single file.
juandausa
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Add the first approach of open file picker. * use getDirectory method and fix some warnings. * Refactor. * Update file selector by adding the confirmation button text and the title. * Remove warnings. * Add changes needed for testing. * Rename OpenFilePicker to DartFileSelectorApi. * Removed unused method. * Generate tests for the dart_file_selector_api. * Add FileOpenDialogAPI to decouple the dialog interaction from the dart_file_selector_api. * Add GetFile dart implementation. * Add new methods to the file selector API to make methods available for testing. * Add new methods to file selector api for testing. * Add changes to failing tests. * Use ternaries. * Add more detailed comment and adds Arena. Co-authored-by: eugerossetto <eugenio.rossetto@southworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase instead of merge.