Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new method to
RSI.StateIdArgumentthat takes anything and uses that to construct newStateIdusing the old one as a prefix.why
I seen that in Content.Client there is no consistency in constructing
StateIds using prefixes and values, as sometimes they use-separator, and sometimes not. Also,StateIdexists, but its rarely used, and in context of such generated ids based on prefix,string?is used most of the times.So I added this method to
break all StateIds that dont usenormalize the codebase.-implementation
As of now, the new
Argumentmethod lives inStateIdand returnsStateIdmeaning you could use any state id prefix as standaloneStateId. This may not be an optimal solution as putting it into some newStateIdPrefixmight be better for type safety, but Iwas lazydecided to minimize number of required changes to implement it if PR get merged, also Im not sure if there isnt RSI where prefix alone would be valid.