Populate Date header if none supplied#2
Merged
Conversation
By default the Date header is included in the list of signed headers, though it might not even exist on the request. This ensures the header is added if it isn't already there.
azdagron
reviewed
Jul 1, 2018
| values = append(values, fmt.Sprintf("%s: %s", h, req.Host)) | ||
| case "date": | ||
| if req.Header.Get(h) == "" { | ||
| req.Header.Set(h, time.Now().Format(time.RFC1123)) |
Contributor
There was a problem hiding this comment.
This is not a well-formed Date header according to the HTTP RFC. HTTP dates are in RFC1123 format, except they are always represented in UTC time. Another caveat is that the timezone indication is not "UTC", but "GMT".
I'd suggest something like:
req.Header.Set(h, time.Now().UTC().Format(http.TimeFormat))
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! This is fixed now.
azdagron
approved these changes
Jul 1, 2018
azdagron
left a comment
azdagron
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, the Date header is included in the list of signed headers, though it might not exist on the request. This patch ensures the header is always there.