Skip to content

ci: fix outputs generation for v0.23.1#460

Closed
alecbcs wants to merge 33 commits intomainfrom
fix/ci-v1.0-dev
Closed

ci: fix outputs generation for v0.23.1#460
alecbcs wants to merge 33 commits intomainfrom
fix/ci-v1.0-dev

Conversation

@alecbcs
Copy link
Copy Markdown
Member

@alecbcs alecbcs commented Jul 17, 2025

Enabling outputs generation for v1.0-dev prior to release.

@alecbcs alecbcs changed the title ci: fix outputs generation for pre v1.0 ci: fix outputs generation for v0.23.1 Jul 20, 2025
@alecbcs alecbcs force-pushed the fix/ci-v1.0-dev branch 2 times, most recently from cce3080 to 612f07b Compare July 20, 2025 21:57
Comment thread outputs/stacks.sh Outdated
cat "$project/stacks/examples/8.spack.stack.yaml" > ~/stacks/spack.yaml
spack module lmod refresh -y
module use "$HOME/stacks/modules/linux-ubuntu22.04-x86_64/Core"
module use /home/spack/stacks/modules/*/Core
Copy link
Copy Markdown
Member

@haampie haampie Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hard-code home directories, use ~

Comment thread outputs/stacks.sh
@@ -91,7 +91,7 @@ example --tee stacks/modules-1 "module --version"

cat "$project/stacks/examples/8.spack.stack.yaml" > ~/stacks/spack.yaml
spack module lmod refresh -y
Copy link
Copy Markdown
Member

@haampie haampie Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc@12 was a system compiler in the previous image, but that's no longer the case in your updated image.

https://github.com/spack/spack/blob/2bfcc69fa870d3c6919be87593f22647981b648a/lib/spack/spack/modules/lmod.py#L77-L82

@haampie
Copy link
Copy Markdown
Member

haampie commented Jul 21, 2025

The diff is much larger than it should be. Did you see

image

@alecbcs
Copy link
Copy Markdown
Member Author

alecbcs commented Jul 21, 2025

Yes see the workflow config

make -C outputs -j $(nproc) DOCKER_RUN_OPTS="-e COLUMNS=94 -e COLIFY_SIZE=24x94" container=ghcr.io/spack/tutorial

@haampie
Copy link
Copy Markdown
Member

haampie commented Jul 21, 2025

Ah, looks like last time it was run on a VM.

@alecbcs
Copy link
Copy Markdown
Member Author

alecbcs commented Aug 3, 2025

Superseded by #465

@alecbcs alecbcs closed this Aug 3, 2025
@alecbcs alecbcs deleted the fix/ci-v1.0-dev branch August 3, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants