Conversation
…hangelog Completes the 1.8.12 code-rendering work (feature code in 75bb0ff): - unit + end-to-end tests: mermaid fence rewriting (top-level, nested, unclosed), page-scoped runtime injection, and highlight line numbers on/off - docs/CONFIGURATION.md: mermaid + highlight_line_numbers - .ssg.yaml.example and CHANGELOG [1.8.12]
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The published guides/blog (e.g. cloudflare-workers-redirects-and-stripe) showed Mermaid fences that never rendered, and code blocks had no highlighting or line numbers.
What's in it
Mermaid diagrams (GO-073)
mermaid: truerewrites a```mermaidfence into a<pre class="mermaid">block before markdown conversion, so the diagram source passes through verbatim instead of being HTML-escaped (-->) — which is exactly why the fences failed to parse before.Line numbers for code highlighting (GO-074)
highlight_line_numbers: trueprefixes every Chroma-highlighted block with line numbers (requireshighlight: true), viachromahtml.WithLineNumbers.Docs site
docs-site.yamlnow enableshighlight,highlight_line_numbersandmermaid, so the guides/blog render coloured code with line numbers and working diagrams.Verification
go build,gofmt,go vetclean; gosec 0, golangci-lint 0; full test suite green.docs-site.yaml; the blog post now emits<pre class="mermaid">with raw-->, the runtime once, inline highlight colours and per-line numbers.Please review — do not merge yet.