Bump SimDB to get uint64_t support (cherry pick) - #600
Merged
Conversation
kathlenemagnus
approved these changes
Aug 1, 2025
| def __WriteHeader(self, fout, report_name, start_tick, end_tick, meta_kvpairs, trigger_locs): | ||
| if end_tick == -1: | ||
| start_tick = int(start_tick) | ||
| if end_tick == '18446744073709551615': |
Contributor
There was a problem hiding this comment.
Can this be a constant? From the limits lib.
Contributor
Author
There was a problem hiding this comment.
We're trying to keep the map_v2.1 PRs to be cherry-pick only, so I can make a note to fix this in the next push to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick into map_v2.1 before tagging map_v2.1.1