map_v2.1.16 - #643
Merged
Merged
Conversation
This follow-up PR fixes the backwards compatibility issue discussed here: #621 The source of the bug boils down to this: - specify extensions in extension/arch/config file - run the simulation with `--write-final-config` - at runtime, register an extension factory - then create the extension with `getExtension()` (implicit) or `createExtension()` (explicit) - extension subclass `postCreate()` method is called - in `postCreate()`, add some more parameters with default values The bug as reported is that the final config YAML file only has the extension parameters that were given in the input YAML files. The default values added in `postCreate()` do not appear in the final config YAML file. This is different than the first extensions implementation where all parameters are written to the final config regardless. These changes have been tested against Olympia and all regressions pass with no changes required to the Olympia source code. I also manually verified that all parameters show up the same way as before in the final config using the ticket's repro command: `./olympia --write-final-config baseline.yaml --no-run` This was also qualified against internal simulators with the only source changes outlined in an internal ticket. I'll assign the ticket back to Zen to qualify/close it when this PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picked: