Fix extensions issues reported by users - #648
Merged
Merged
Conversation
klingaard
reviewed
Feb 8, 2026
| * \throw If 'this' tree node was given more than one extension in the | ||
| * input YAML files, this will always throw an exception. | ||
| */ | ||
| ExtensionsBase * createExtension(bool replace=false); |
Member
There was a problem hiding this comment.
If I replace an extension... if the previous extension had settings, are they lost?
Contributor
Author
There was a problem hiding this comment.
If you do this:
auto ext1 = node->createExtension("name");
It gets auto-populated with the YAML parameter values. If you make changes to those parameter values on your own, then do this:
auto ext2 = node->createExtension("name", true); // replace
Then it's auto-populated with the YAML values again, and the changes you made on your own are lost.
If that didn't happen, i.e. if the replaced extension carried over the prior extension's values, then I think the idea of letting extensions be replaced ceases to make sense since they are identical except they are just different instances.
klingaard
approved these changes
Feb 8, 2026
klingaard
left a comment
klingaard
left a comment
Member
There was a problem hiding this comment.
Once the failures are addressed, looks good to merge
colby-nyce
marked this pull request as ready for review
February 9, 2026 03:27
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
This PR fixes the "unread unbound parameter" exceptions / prints to stdout that were recently reported due to the tree node extensions redesign. 9fbadc1
colby-nyce
added a commit
that referenced
this pull request
Feb 9, 2026
This PR fixes the "unread unbound parameter" exceptions / prints to stdout that were recently reported due to the tree node extensions redesign.
colby-nyce
added a commit
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the "unread unbound parameter" exceptions / prints to stdout that were recently reported due to the tree node extensions redesign.