Skip to content

Some branch work to support using PR tools to support the repo code review on 5/28 - #1

Closed
gigapod wants to merge 3 commits into
emptyfrom
review
Closed

Some branch work to support using PR tools to support the repo code review on 5/28#1
gigapod wants to merge 3 commits into
emptyfrom
review

Conversation

@gigapod

@gigapod gigapod commented May 27, 2026

Copy link
Copy Markdown
Member

Node

I created a empty branch and a review branch (that contained main) to allow review of all the code for the initial review

Comment thread src/SparkFun_ADE7953.h
Comment thread src/SparkFun_ADE7953.h
Comment thread src/SparkFun_ADE7953.h
@edspark

edspark commented May 28, 2026

Copy link
Copy Markdown

Needs a "Documentation" folder with the relevant datasheet in it.

Comment thread src/sfTk/sfDevADE7953.h
Comment thread src/sfTk/sfDevADE7953.h
Comment thread library.properties
Comment thread library.properties
Comment thread examples/Example06_InterruptPin/Example06_InterruptPin.ino
Comment thread src/sfTk/sfDevADE7953.cpp
Comment thread src/sfTk/sfDevADE7953.cpp

@sfe-SparkFro sfe-SparkFro left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review from Claude. I haven't really read these yet, just posting so we can all review and discuss.

Comment thread src/sfTk/sfDevADE7953.cpp
Comment thread src/sfTk/sfDevADE7953.cpp
Comment thread src/sfTk/sfDevADE7953.cpp
Comment thread src/sfTk/sfDevADE7953.h
Comment thread src/SparkFun_ADE7953.h
Comment thread src/sfTk/sfDevADE7953.cpp
Comment thread src/sfTk/sfDevADE7953.cpp
Comment thread src/sfTk/sfDevADE7953.h
Comment thread src/sfTk/sfDevADE7953.cpp
Comment thread src/sfTk/sfDevADE7953.h
@FacioErgoSum
FacioErgoSum deleted the branch empty June 2, 2026 16:25
@FacioErgoSum
FacioErgoSum deleted the review branch June 2, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants