Remove deprecated taint followup#277
Merged
tenderlove merged 3 commits intosparklemotion:masterfrom Dec 18, 2019
Merged
Conversation
The Ruby core team decided to deprecate the taint mechanism in Ruby 2.7 and will remove that in Ruby 3. https://bugs.ruby-lang.org/issues/16131 ruby/ruby#2476 In Ruby 2.7, `Object#{taint,untaint,trust,untrust}` and related functions in the C-API no longer have an effect (all objects are always considered untainted), and are now warned deprecation message. https://buildkite.com/rails/rails/builds/65054#5aa2db21-569d-4202-99cd-a8323cab583e/6-8
casperisfine
force-pushed
the
remove_deprecated_taint-followup
branch
from
2b40d08 to
0b5e04e
Compare
casperisfine
force-pushed
the
remove_deprecated_taint-followup
branch
from
0b5e04e to
19d0486
Compare
Member
|
Thank you! |
|
Thank you |
composerinteralia
added a commit
to thoughtbot/factory_bot
that referenced
this pull request
Jul 15, 2020
Ruby 3 is not compatible with Rails 5.0. Rails 5.0 locked to sqlite3 "~> 1.3.6", but only sqlite3 "<= 1.4.2" is compatible with Ruby 3. [Older versions of sqlite3 referenced `rb_check_safe_obj`][sqlite3], which raised a warning in Ruby 2.7 and will fail in Ruby 3.0. Since this combination of tests will always fail, this commit updates Travis to stop running it. [sqlite3]: sparklemotion/sqlite3-ruby#277
composerinteralia
added a commit
to thoughtbot/factory_bot
that referenced
this pull request
Jul 15, 2020
Ruby 3 is not compatible with Rails 5.0. Rails 5.0 locked to sqlite3 "~> 1.3.6", but only sqlite3 "<= 1.4.2" is compatible with Ruby 3. [Older versions of sqlite3 referenced `rb_check_safe_obj`][sqlite3], which raised a warning in Ruby 2.7 and will fail in Ruby 3.0. Since this combination of tests will always fail, this commit updates Travis to stop running it. [sqlite3]: sparklemotion/sqlite3-ruby#277
connorchris831
pushed a commit
to connorchris831/factory_bot
that referenced
this pull request
Dec 13, 2022
Ruby 3 is not compatible with Rails 5.0. Rails 5.0 locked to sqlite3 "~> 1.3.6", but only sqlite3 "<= 1.4.2" is compatible with Ruby 3. [Older versions of sqlite3 referenced `rb_check_safe_obj`][sqlite3], which raised a warning in Ruby 2.7 and will fail in Ruby 3.0. Since this combination of tests will always fail, this commit updates Travis to stop running it. [sqlite3]: sparklemotion/sqlite3-ruby#277
SriHarshaxi
pushed a commit
to SriHarshaxi/factory_bot
that referenced
this pull request
Mar 17, 2023
Ruby 3 is not compatible with Rails 5.0. Rails 5.0 locked to sqlite3 "~> 1.3.6", but only sqlite3 "<= 1.4.2" is compatible with Ruby 3. [Older versions of sqlite3 referenced `rb_check_safe_obj`][sqlite3], which raised a warning in Ruby 2.7 and will fail in Ruby 3.0. Since this combination of tests will always fail, this commit updates Travis to stop running it. [sqlite3]: sparklemotion/sqlite3-ruby#277
gold-crow-997
added a commit
to gold-crow-997/factory-bot
that referenced
this pull request
Jun 8, 2025
Ruby 3 is not compatible with Rails 5.0. Rails 5.0 locked to sqlite3 "~> 1.3.6", but only sqlite3 "<= 1.4.2" is compatible with Ruby 3. [Older versions of sqlite3 referenced `rb_check_safe_obj`][sqlite3], which raised a warning in Ruby 2.7 and will fail in Ruby 3.0. Since this combination of tests will always fail, this commit updates Travis to stop running it. [sqlite3]: sparklemotion/sqlite3-ruby#277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup on @kamipo's #273
It also avoid calling
rb_check_safe_objon MRI 2.7. That warning is totally spamming Active Record's test suite.cc @tenderlove since apparently you're maintainer.
cc @rafaelfranca @Edouard-chin.
NB: Based on @kamipo's PR I expect half of the CI jobs to fail, I'll try to make them pass by pushing another commit.