Provide exit code in CouldNotFetchDns exception

[dennis-koster]

Last night a couple occurrences were logged of the CouldNotFetchDns exception.

Spatie\Dns\Exceptions\CouldNotFetchDns Dig command `dig +nocmd +noall +noidnout +authority +answer +nomultiline +answer +tries=2 +time=2 @8.8.8.8 -q <domain name here> -t CNAME` failed with message: `;; IDN output support not enabled` 
    vendor/spatie/dns/src/Exceptions/CouldNotFetchDns.php:23 Spatie\Dns\Exceptions\CouldNotFetchDns::digReturnedWithError
    vendor/spatie/dns/src/Handlers/Dig.php:27 Spatie\Dns\Handlers\Dig::__invoke
    vendor/spatie/dns/src/Dns.php:90 Spatie\Dns\Dns::getRecords

It makes it seem as if the message ;; IDN output support not enabled was the error, which sent me spiralling trying to debug that message. It turns out that message is just a warning that seems tricky to get rid off.

The exception was thrown because an unsuccessful exit code was returned by dig, but that exit code is not provided in the exception. This makes it quite hard / impossible for me to figure out what the actual error was.

I think it would be helpful to provide the exit code in the exception and potentially also just ignore ;; IDN output support not enabled as an error.

[freekmurze]

Thanks for the detailed report, @dennis-koster!

This is fixed in v2.8.0. CouldNotFetchDns now leads with dig's exit code (mapped to its documented meaning where known) and exposes it via an $exitCode property, so you can inspect it programmatically:

catch (CouldNotFetchDns $exception) {
    $exception->exitCode; // e.g. 9
}

The message now reads like:

Dig command `...` failed with exit code 9 (no reply from server): `;; IDN output support not enabled`

The ;; IDN output support not enabled warning is no longer treated as the error. It's kept as supplementary context rather than masquerading as the cause, since it can still be useful for internationalized domains.

Done in #124.

[dennis-koster]

Amazing, thanks for the quick response!