Skip to content

Add optional args to DockerContainer class#37

Merged
freekmurze merged 2 commits intospatie:mainfrom
wajdijurry:add-optional-args
May 27, 2022
Merged

Add optional args to DockerContainer class#37
freekmurze merged 2 commits intospatie:mainfrom
wajdijurry:add-optional-args

Conversation

@wajdijurry
Copy link
Contributor

This PR aims to add ability to add optional arguments to docker run command through DockerContainer class.
Example:

$container = DockerContainer::create($imageName, $containerName)
    ->setOptionalArgs('-it', '-a')
    ->start();

Notes:

  1. README.md updated
  2. New test case added

@wajdijurry wajdijurry marked this pull request as ready for review May 27, 2022 13:32
@freekmurze freekmurze changed the title Add optional args tp DockerContainer class Add optional args to DockerContainer class May 27, 2022
@freekmurze freekmurze merged commit 69b86f4 into spatie:main May 27, 2022
@freekmurze
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants