Add VOs with query param options #3
Conversation
| public ?bool $active = null, | ||
| public ?string $projectCode = null, | ||
| public ?int $clientId = null, | ||
| public ?bool $nonBillable = null, | ||
| public ?string $tagName = null, | ||
| public ?string $modifiedSince = null, | ||
| public ?array $fields = null, | ||
| public ?array $expand = null, | ||
| ?int $page = null, | ||
| ?int $perPage = null, | ||
| ?string $sort = null, |
There was a problem hiding this comment.
Are these really all nullable? I'd also add the project id here, or is that project code in Float?
There was a problem hiding this comment.
Yes, everything is optional: https://developer.float.com/api_reference.html#!/Projects/getProjects
I'd add a different GetProjectRequest to retrieve a single project.
https://developer.float.com/api_reference.html#!/Projects/getProject
| * @param array<string>|null $fields | ||
| */ | ||
| public function __construct( | ||
| public ?int $projectId = null, |
There was a problem hiding this comment.
I think we'll also need the task_id
There was a problem hiding this comment.
We can add a separate request for this: https://developer.float.com/api_reference.html#!/Project_Tasks/getProjectTask
| * @param ?array<string> $expand | ||
| */ | ||
| public function __construct( | ||
| public ?bool $active = null, |
There was a problem hiding this comment.
We'll need the user id to link our users to float users, I guess we could use email as well though 🤔
not used
No description provided.