Memory improvements by only returning the needed JSON output via NodeJS#63
Merged
freekmurze merged 5 commits intospatie:mainfrom Oct 3, 2025
Merged
Memory improvements by only returning the needed JSON output via NodeJS#63freekmurze merged 5 commits intospatie:mainfrom
freekmurze merged 5 commits intospatie:mainfrom
Conversation
…ve the other 95% of the runnerResult JSON blob)
Member
|
Great work, I didn't realize these reports were so big. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NodeJS wrapper returned the entire JSON output of the Lighthouse check, which contains 3 major blocks:
We only need the HTML & JSON output that is in
reportand any runtime errors inlhr, the rest currently isn't used. This PR filters only the necessary fields in NodeJS and prevents PHP from re-encoding the JSON string, which in extreme cases causes out-of-memory issues.This PR remains simple and if there's ever a need for more data out of the Lighthouse package, it should be simple to extend the NodeJS output.
Peak memory usage results from testing:
Even in simple HTML examples the gains are ~50%, in edge-cases (ie complex sites) it can be as high is 90%+.