Fix crash when using JoliNotif@3
#179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! |
Contributor
Author
|
Thank you for the review and for publishing! I have confirmed in my local project that, with the latest version (1.24.4), OS notifications work without any issues when used together with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for sending multiple pull requests in quick succession.
I realized that the support for
JoliNotif@3added in #178 was incomplete. With the current implementation, our tool crashes when it attempts to send a notification to the operating system.This pull request updates our library to handle the breaking changes introduced in
JoliNotif@3. At the same time, it adds a feature-detection–based fallback so that the library continues to work with older versions ofJoliNotifas well.Because this code integrates with an external library to send OS-level notifications, I was unable to write unit tests. However, I have verified in my local environment that it works correctly with both the newer and older versions of
JoliNotif.