Added an error dialog for showing export errors in run browser.#369
Merged
Conversation
cjsunatgh
reviewed
Feb 7, 2025
| await self.db_task(self.db.export_runs(filenames, formats=formats), "export") | ||
| try: | ||
| await self.db_task( | ||
| self.db.export_runs(filenames, formats=formats), "export" |
Collaborator
There was a problem hiding this comment.
await self.db_task(self.db.export_runs(filenames, formats=formats), "export") is called twice, was it intentional?
Contributor
Author
There was a problem hiding this comment.
The red line is what was removed, and the green line is what replaces it. So I took out
await self.db_task(self.db.export_runs(filenames, formats=formats), "export")
and replaced it with
try:
await self.db_task(
self.db.export_runs(filenames, formats=formats), "export"
cjsunatgh
reviewed
Feb 7, 2025
| ) | ||
| except httpx.HTTPStatusError as exc: | ||
| log.exception(exc) | ||
| msg = "Scan export failed. See Tiled server logs for details." |
Collaborator
There was a problem hiding this comment.
I do not know, but I assume that we do not need the details of error code, if needed, we can go to the Titled server logs
Contributor
Author
There was a problem hiding this comment.
We do get some additional information actually. I can provide these details in the error message.
cjsunatgh
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly's run browser can export scans through Tiled. If Tiled fails to export a scan, the error was only present in the Firefly console. This PR adds a QErrorMessage that reports to the operator that the export failed.
Things to do before merging:
add testswrite docsupdate iconfig_testing.toml