Make DaCe Folder Self Consistent (again)#2355
Merged
tbennun merged 3 commits intoMay 20, 2026
Merged
Conversation
This is needed to make it self consistent. However, it is technically not the best solution.
philip-paul-mueller
marked this pull request as ready for review
May 8, 2026 09:33
tbennun
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR#2331 and PR#2348 the possibility of different folder modes/versions was introduced with the goal of reducing the size of the generated folder. The idea was to "only dump what is needed".
In
productionprogram.sdfgz(serialized SDFG) was not dumped. This had the effect that it is not possible to construct aCompiledSDFGobject (and call the SDFG from Python) without having the source SDFG in the first place. This PR solves this issue by again dumping the SDFG.Note in the long run one should switch to
nanobindinstead ofctype, which would make the binary an importable package and would also allow to offload the processing of the arguments toC++.For more information on this see issue#2362.